dwarf2_loc_mark_labels conflict. x86_gcc2

[kallisti5]

./configure --build-cross-tools x86_gcc2 ../../buildtools --build-cross-tools x86
.
.
gcc -DHAVE_CONFIG_H -I. -I/home/kallisti5/Code/buildtools/legacy/binutils/gas -I. -D_GNU_SOURCE -I. -I/home/kallisti5/Code/buildtools/legacy/binutils/gas -I../bfd -I/home/kallisti5/Code/buildtools/legacy/binutils/gas/config -I/home/kallisti5/Code/buildtools/legacy/binutils/gas/../include -I/home/kallisti5/Code/buildtools/legacy/binutils/gas/.. -I/home/kallisti5/Code/buildtools/legacy/binutils/gas/../bfd -I/home/kallisti5/Code/buildtools/legacy/binutils/gas/../intl -I../intl -DLOCALEDIR="\"/home/kallisti5/Code/haiku/generated.x86_gcc2/cross-tools-x86_gcc2/share/locale\""   -W -Wall -Wstrict-prototypes -Wmissing-prototypes -O2  -c /home/kallisti5/Code/buildtools/legacy/binutils/gas/config/atof-ieee.c
/bin/sh ./libtool --mode=link gcc -W -Wall -Wstrict-prototypes -Wmissing-prototypes -O2    -o as-new  app.o as.o atof-generic.o cond.o depend.o dwarf2dbg.o dw2gencfi.o ecoff.o ehopt.o expr.o flonum-copy.o flonum-konst.o flonum-mult.o frags.o hash.o input-file.o input-scrub.o listing.o literal.o macro.o messages.o output-file.o read.o sb.o stabs.o subsegs.o symbols.o write.o tc-i386.o obj-elf.o atof-ieee.o  ../bfd/libbfd.la ../libiberty/libiberty.a   
mkdir .libs
gcc -W -Wall -Wstrict-prototypes -Wmissing-prototypes -O2 -o .libs/as-new app.o as.o atof-generic.o cond.o depend.o dwarf2dbg.o dw2gencfi.o ecoff.o ehopt.o expr.o flonum-copy.o flonum-konst.o flonum-mult.o frags.o hash.o input-file.o input-scrub.o listing.o literal.o macro.o messages.o output-file.o read.o sb.o stabs.o subsegs.o symbols.o write.o tc-i386.o obj-elf.o atof-ieee.o  ../bfd/.libs/libbfd.so -L/home/kallisti5/Code/haiku/generated.x86_gcc2/cross-tools-x86_gcc2-build/binutils/libiberty/pic -liberty ../libiberty/libiberty.a -Wl,--rpath -Wl,/home/kallisti5/Code/haiku/generated.x86_gcc2/cross-tools-x86_gcc2/x86_64-unknown-linux-gnu/i586-pc-haiku/lib
/usr/bin/ld: as.o:(.bss+0x150): multiple definition of `dwarf2_loc_mark_labels'; app.o:(.bss+0x0): first defined here
/usr/bin/ld: atof-generic.o:(.bss+0x0): multiple definition of `dwarf2_loc_mark_labels'; app.o:(.bss+0x0): first defined here
/usr/bin/ld: cond.o:(.bss+0x58): multiple definition of `dwarf2_loc_mark_labels'; app.o:(.bss+0x0): first defined here
/usr/bin/ld: depend.o:(.bss+0x0): multiple definition of `dwarf2_loc_mark_labels'; app.o:(.bss+0x0): first defined here
/usr/bin/ld: dwarf2dbg.o:(.bss+0x0): multiple definition of `dwarf2_loc_mark_labels'; app.o:(.bss+0x0): first defined here
/usr/bin/ld: dw2gencfi.o:(.bss+0x0): multiple definition of `dwarf2_loc_mark_labels'; app.o:(.bss+0x0): first defined here
/usr/bin/ld: ecoff.o:(.bss+0x0): multiple definition of `dwarf2_loc_mark_labels'; app.o:(.bss+0x0): first defined here
/usr/bin/ld: ehopt.o:(.bss+0x0): multiple definition of `dwarf2_loc_mark_labels'; app.o:(.bss+0x0): first defined here
/usr/bin/ld: expr.o:(.bss+0x34): multiple definition of `dwarf2_loc_mark_labels'; app.o:(.bss+0x0): first defined here
/usr/bin/ld: flonum-copy.o:(.bss+0x0): multiple definition of `dwarf2_loc_mark_labels'; app.o:(.bss+0x0): first defined here
/usr/bin/ld: frags.o:(.bss+0x0): multiple definition of `dwarf2_loc_mark_labels'; app.o:(.bss+0x0): first defined here
/usr/bin/ld: hash.o:(.bss+0x0): multiple definition of `dwarf2_loc_mark_labels'; app.o:(.bss+0x0): first defined here
/usr/bin/ld: input-file.o:(.bss+0x4): multiple definition of `dwarf2_loc_mark_labels'; app.o:(.bss+0x0): first defined here
/usr/bin/ld: input-scrub.o:(.bss+0x4): multiple definition of `dwarf2_loc_mark_labels'; app.o:(.bss+0x0): first defined here
/usr/bin/ld: listing.o:(.bss+0x8): multiple definition of `dwarf2_loc_mark_labels'; app.o:(.bss+0x0): first defined here
/usr/bin/ld: literal.o:(.bss+0x0): multiple definition of `dwarf2_loc_mark_labels'; app.o:(.bss+0x0): first defined here
/usr/bin/ld: macro.o:(.bss+0x10): multiple definition of `dwarf2_loc_mark_labels'; app.o:(.bss+0x0): first defined here
/usr/bin/ld: messages.o:(.bss+0x0): multiple definition of `dwarf2_loc_mark_labels'; app.o:(.bss+0x0): first defined here
/usr/bin/ld: output-file.o:(.bss+0x8): multiple definition of `dwarf2_loc_mark_labels'; app.o:(.bss+0x0): first defined here
/usr/bin/ld: read.o:(.bss+0xc8): multiple definition of `dwarf2_loc_mark_labels'; app.o:(.bss+0x0): first defined here
/usr/bin/ld: sb.o:(.bss+0x0): multiple definition of `dwarf2_loc_mark_labels'; app.o:(.bss+0x0): first defined here
/usr/bin/ld: stabs.o:(.bss+0x4): multiple definition of `dwarf2_loc_mark_labels'; app.o:(.bss+0x0): first defined here
/usr/bin/ld: subsegs.o:(.bss+0x10): multiple definition of `dwarf2_loc_mark_labels'; app.o:(.bss+0x0): first defined here
/usr/bin/ld: symbols.o:(.bss+0xf8): multiple definition of `dwarf2_loc_mark_labels'; app.o:(.bss+0x0): first defined here
/usr/bin/ld: write.o:(.bss+0x18): multiple definition of `dwarf2_loc_mark_labels'; app.o:(.bss+0x0): first defined here
/usr/bin/ld: tc-i386.o:(.bss+0x8): multiple definition of `dwarf2_loc_mark_labels'; app.o:(.bss+0x0): first defined here
/usr/bin/ld: obj-elf.o:(.bss+0x8): multiple definition of `dwarf2_loc_mark_labels'; app.o:(.bss+0x0): first defined here
/usr/bin/ld: atof-ieee.o:(.bss+0x0): multiple definition of `dwarf2_loc_mark_labels'; app.o:(.bss+0x0): first defined here
collect2: error: ld returned 1 exit status
make[4]: *** [Makefile:2551: as-new] Error 1
make[4]: Leaving directory '/home/kallisti5/Code/haiku/generated.x86_gcc2/cross-tools-x86_gcc2-build/binutils/gas'

Build system:

• Fedora 32
• gcc version 10.2.1 20200723 (Red Hat 10.2.1-1) (GCC)

[kallisti5]

fix in flight for this one. gcc10 changed from -fcommon to -fno-common which breaks the gcc2 build under gcc10.

Adding -fcommon to our toolchain build script resolves this issue and should be somewhat portable between gcc's 4-10

[kallisti5]

Resolved via hrev54648