ObjectDeleter: size in twice bigger then regular pointer

[X512]

This is hrev54752.

AutoDeleter use DeleteFunc fDelete field. C++ don't like zero field size and adjust it to 1 byte. After alignment ObjectDeleter size become 2*sizeof(void*). See test code.

There are no such problem in std::unique_ptr. It use some C++ tricks that need to be investigated and reused in AutoDeleter.h.

[X512]

Test program output:

sizeof(ptr1): 8
sizeof(ptr2): 16
sizeof(ptr3): 8

[X512]

Following trick can fix issue:

headers/private/shared/AutoDeleter.h

@@ -29 +29 @@
 class AutoDeleter {
 public:
     inline AutoDeleter()
-        : fObject(NULL)
+        : fInt(NULL)
     {
     }
 
     inline AutoDeleter(C *object)
-        : fObject(object)
+        : fInt(object)
     {
     }
 
     inline ~AutoDeleter()
     {
-        fDelete(fObject);
+        fInt(fInt.fObject);
     }
 
     inline void SetTo(C *object)
     {
-        if (object != fObject) {
-            fDelete(fObject);
-            fObject = object;
+        if (object != fInt.fObject) {
+            fInt(fInt.fObject);
+            fInt.fObject = object;
         }
     }
 
@@ -63 +63 @@
 
     inline C *Get() const
     {
-        return fObject;
+        return fInt.fObject;
     }
 
     inline C *Detach()
     {
-        C *object = fObject;
-        fObject = NULL;
+        C *object = fInt.fObject;
+        fInt.fObject = NULL;
         return object;
     }
 
     inline C *operator->() const
     {
-        return fObject;
+        return fInt.fObject;
     }
 
 protected:
-    C           *fObject;
-    DeleteFunc  fDelete;
+    struct Internal: DeleteFunc {
+        C* fObject;
+        inline Internal(C *object): fObject(object) {}
+    } fInt;
 
 private:
     AutoDeleter(const AutoDeleter&);

[X512]

Similar problem with CObjectDeleter, but it actually store pointer to destructor function. I suggest interface change from CObjectDeleter<Type, DestructorResult> ptr(val, destructor) to CObjectDeleter<Type, DestructorResult, destructor> ptr(val). It will also allow to declare typedef for specific pointer type with destructor function.

[X512]

Fixed in hrev54773.