Opened 4 years ago

Last modified 17 months ago

#16876 new bug

Webkit: "Search the web" does not respect user preferences

Reported by: nephele Owned by: pulkomandy
Priority: normal Milestone: Unscheduled
Component: Kits/Web Kit Version: R1/Development
Keywords: Cc:
Blocked By: Blocking: #16902
Platform: All

Description (last modified by nephele)

This is hrev55008 (hrev55009+3)
The webkit build is on commit 24f821fce0128e8fd28e97f064e891dfacc193a8

For reference this always uses google.com as a search engine, the default was changed in WebPositive to duckduckgo.com though, so this is a bit more noticeable now

Change History (3)

comment:1 by nephele, 4 years ago

Description: modified (diff)

comment:2 by humdinger, 4 years ago

Blocking: 16902 added

comment:3 by pulkomandy, 17 months ago

This is hardcoded in Source/WebKitLegacy/haiku/WebCoreSupport/ContextMenuClientHaiku.cpp

I see two options to change it:

  • The browser could configure haikuwebkit to set a preferred search engine, that would be used here
  • Or, this code could be changed to send a message to the browser, eventually triggering BrowserWindow::_VisitSearchEngine in WebPositive

I think the second solution makes more sense, ideally we should move as much as possible of the context menu handling inside WebPositive and not on WebKit side.

Note: See TracTickets for help on using tickets.