Opened 4 years ago
Last modified 4 years ago
#16974 new bug
src/tools/checkstyle/checkstyle.py needs updated or tossed
| Reported by: | kallisti5 | Owned by: | bonefish |
|---|---|---|---|
| Priority: | low | Milestone: | Unscheduled |
| Component: | Build System | Version: | R1/Development |
| Keywords: | stylecheck | Cc: | |
| Blocked By: | Blocking: | ||
| Platform: | All |
Description
src/tools/checkstyle/checkstyle.py only works under python2. A few minutes looking at it, and the whole visit / os.path.walk system needs redesigned for python3+
The tool also flags a *lot* of false positives when run on our source code.
We need to update it and make it detect actual style issues like incorrect const names, etc... or toss it as it leads towards confusion.
It does do a few things correctly like line length > 80 and lack of spaces between =,>,<, etc.
Note:
See TracTickets
for help on using tickets.
It should be deleted and we should use clang-tidy or clang-format instead.
It doesn't do the 80 column check correctly because it doesn't know that tabs count for more than one space, for example. There is no need to spend time on this when better tools are available.