Opened 3 years ago

Last modified 3 years ago

#17030 new bug

uname not showing r1beta3

Reported by: kallisti5 Owned by: nobody
Priority: normal Milestone: Unscheduled
Component: Applications Version: R1/beta3
Keywords: uname Cc:
Blocked By: Blocking:
Platform: All

Description

Just noticed that uname is not showing "r1beta3" anywhere in it.

Not sure if that's expected, but we might want to address it.

Attachments (1)

uname.png (108.6 KB ) - added by kallisti5 3 years ago.

Download all attachments as: .zip

Change History (10)

by kallisti5, 3 years ago

Attachment: uname.png added

comment:1 by kallisti5, 3 years ago

The AboutSystem window gets the branch name from the BEOS:APP_VERSION of libbe.so. (src/apps/aboutsystem/AboutSystem.cpp)

uname gets the version as the hrev from get_haiku_revision() (src/system/libroot/posix/sys/uname.c)

Ideally, maybe uname.c should see a "non-nightly" (Walter) version in BEOS:APP_VERSION and report the branch instead of the hrev?

comment:2 by kallisti5, 3 years ago

The alternative would be reporting branch(hrev...) in uname. Example:

Version 1, edited 3 years ago by kallisti5 (previous) (next) (diff)

comment:3 by pulkomandy, 3 years ago

This should not be patched in uname. Instead, we should give "real" versions to releases instead of using hrevs there. But the ticket about that was closed without actually making any changes during the beta1 release process. And so we have this stupid versionning scheme where the haiku package version is something like "R1~beta3_hrev12345+8" where it should just be "R1~beta3+15" or something simple like that (with the 15 being the number of commits since the beta tag).

Last edited 3 years ago by pulkomandy (previous) (diff)

comment:4 by pulkomandy, 3 years ago

Actually "uname -r" (kernel release) just returns "1" for Haiku R1. I think we should keep it that way and update it to 1.1, 1.2, etc for releases after R1.

In theory we could put 1~beta3 there but I think it will just confuse tools trying to parse uname output?

comment:5 by kallisti5, 3 years ago

The kernel release doesn't show up in uname -a which is what most programs use for identification.

1~beta3 (or 1.0~beta3) seems reasonable?

uname -k giving a "1" isn't very descriptive anyway :-)

comment:6 by kallisti5, 3 years ago

nevermind.. you're right. the 1 is in "uname -a" Theoretically appending stuff onto the 1 shouldn't break parsing.. most things just split on space.

Linux: Linux eris.discord.local 5.12.13-arch1-2 #1 SMP PREEMPT Fri, 25 Jun 2021 22:56:51 +0000 x86_64 GNU/Linux

Haiku: Haiku shredder 1 hrev55181+16 Jun 29 2021 20:25: x86_64 x86_64 Haiku

Just noticed our kernel "version" has an extra : on the end which seems odd. Something getting cut off?

in reply to:  6 comment:7 by madmax, 3 years ago

Replying to kallisti5:

Just noticed our kernel "version" has an extra : on the end which seems odd. Something getting cut off?

Yeah, not an extra : but the seconds being cut off. It's strlcatting revision with build date and time in a 32 bytes string and the last two chars don't fit in this case.

comment:8 by nielx, 3 years ago

Milestone: R1/beta3R1/beta4

Ticket retargeted after milestone closed

comment:9 by pulkomandy, 3 years ago

Milestone: R1/beta4Unscheduled

Moving various tickets out of the beta4 milestone because no one is actively working on them.

Note: See TracTickets for help on using tickets.