Webkit 612.1.24: ScrollbarThemeHaiku.cpp build issue

[cocobean]

Tested on hrev55181+38 w/Webkit 612.1.24:

[1644/4101] Building CXX object Source...atform/haiku/ScrollbarThemeHaiku.cpp.o
FAILED: Source/WebCore/CMakeFiles/WebCore.dir/platform/haiku/ScrollbarThemeHaiku.cpp.o 
/boot/system/bin/x86/c++ -DBUILDING_HAIKU__=1 -DBUILDING_WITH_CMAKE=1 -DBUILDING_WebCore -DDATA_DIR=\"/boot/system/data/WebKit\" -DHAIKU_WEBKIT_VERSION=\"1.8.2\" -DHAVE_CONFIG_H=1 -DSTATICALLY_LINKED_WITH_PAL -DUSE_3D_GRAPHICS=0 -D_GLIBCXX_USE_C99_MATH -I../../Source/ThirdParty/ANGLE -I../../Source/ThirdParty/ANGLE/include/KHR -I../../Source/WebCore/page/scrolling/coordinatedgraphics -I../../Source/WebCore/platform/haiku -I../../Source/WebCore/platform/graphics/egl -I../../Source/WebCore/platform/graphics/haiku -I../../Source/WebCore/platform/graphics/opengl -I../../Source/WebCore/platform/graphics/opentype -I../../Source/WebCore/platform/graphics/texmap/coordinated -I../../Source/WebCore/platform/mediacapabilities -I../../Source/WebCore/platform/network/haiku -IDerivedSources/ForwardingHeaders/JavaScriptCore -I../../Source -I. -IWebCore/DerivedSources -I../../Source/WebCore -I../../Source/WebCore/Modules/airplay -I../../Source/WebCore/Modules/applepay -I../../Source/WebCore/Modules/applepay/paymentrequest -I../../Source/WebCore/Modules/applicationmanifest -I../../Source/WebCore/Modules/async-clipboard -I../../Source/WebCore/Modules/beacon -I../../Source/WebCore/Modules/cache -I../../Source/WebCore/Modules/contact-picker -I../../Source/WebCore/Modules/credentialmanagement -I../../Source/WebCore/Modules/encryptedmedia -I../../Source/WebCore/Modules/encryptedmedia/legacy -I../../Source/WebCore/Modules/entriesapi -I../../Source/WebCore/Modules/fetch -I../../Source/WebCore/Modules/geolocation -I../../Source/WebCore/Modules/highlight -I../../Source/WebCore/Modules/indexeddb -I../../Source/WebCore/Modules/indexeddb/client -I../../Source/WebCore/Modules/indexeddb/server -I../../Source/WebCore/Modules/indexeddb/shared -I../../Source/WebCore/Modules/mediacapabilities -I../../Source/WebCore/Modules/mediacontrols -I../../Source/WebCore/Modules/mediarecorder -I../../Source/WebCore/Modules/mediasession -I../../Source/WebCore/Modules/mediasource -I../../Source/WebCore/Modules/mediastream -I../../Source/WebCore/Modules/mediastream/libwebrtc -I../../Source/WebCore/Modules/model-element -I../../Source/WebCore/Modules/navigatorcontentutils -I../../Source/WebCore/Modules/notifications -I../../Source/WebCore/Modules/paymentrequest -I../../Source/WebCore/Modules/pictureinpicture -I../../Source/WebCore/Modules/plugins -I../../Source/WebCore/Modules/remoteplayback -I../../Source/WebCore/Modules/speech -I../../Source/WebCore/Modules/streams -I../../Source/WebCore/Modules/webaudio -I../../Source/WebCore/Modules/webauthn -I../../Source/WebCore/Modules/webauthn/cbor -I../../Source/WebCore/Modules/webauthn/fido -I../../Source/WebCore/Modules/webdatabase -I../../Source/WebCore/Modules/webdriver -I../../Source/WebCore/Modules/webgpu -I../../Source/WebCore/Modules/webgpu/WHLSL -I../../Source/WebCore/Modules/webgpu/WHLSL/AST -I../../Source/WebCore/Modules/websockets -I../../Source/WebCore/Modules/webxr -I../../Source/WebCore/accessibility -I../../Source/WebCore/accessibility/isolatedtree -I../../Source/WebCore/animation -I../../Source/WebCore/bindings -I../../Source/WebCore/bindings/js -I../../Source/WebCore/bridge -I../../Source/WebCore/bridge/c -I../../Source/WebCore/bridge/jsc -I../../Source/WebCore/contentextensions -I../../Source/WebCore/crypto -I../../Source/WebCore/crypto/algorithms -I../../Source/WebCore/crypto/keys -I../../Source/WebCore/crypto/parameters -I../../Source/WebCore/css/calc -I../../Source/WebCore/css/parser -I../../Source/WebCore/css/typedom -I../../Source/WebCore/cssjit -I../../Source/WebCore/display -I../../Source/WebCore/display/compositing -I../../Source/WebCore/display/css -I../../Source/WebCore/dom/messageports -I../../Source/WebCore/domjit -I../../Source/WebCore/editing -I../../Source/WebCore/history -I../../Source/WebCore/html -I../../Source/WebCore/html/canvas -I../../Source/WebCore/html/forms -I../../Source/WebCore/html/parser -I../../Source/WebCore/html/shadow -I../../Source/WebCore/html/track -I../../Source/WebCore/inspector -I../../Source/WebCore/inspector/agents -I../../Source/WebCore/inspector/agents/page -I../../Source/WebCore/inspector/agents/worker -I../../Source/WebCore/layout -I../../Source/WebCore/layout/formattingContexts -I../../Source/WebCore/layout/formattingContexts/block -I../../Source/WebCore/layout/formattingContexts/block/tablewrapper -I../../Source/WebCore/layout/formattingContexts/flex -I../../Source/WebCore/layout/floats -I../../Source/WebCore/layout/formattingContexts/inline -I../../Source/WebCore/layout/formattingContexts/inline/text -I../../Source/WebCore/layout/integration -I../../Source/WebCore/layout/invalidation -I../../Source/WebCore/layout/layouttree -I../../Source/WebCore/layout/formattingContexts/table -I../../Source/WebCore/loader -I../../Source/WebCore/loader/appcache -I../../Source/WebCore/loader/archive -I../../Source/WebCore/loader/archive/mhtml -I../../Source/WebCore/loader/cache -I../../Source/WebCore/loader/icon -I../../Source/WebCore/mathml -I../../Source/WebCore/page -I../../Source/WebCore/page/csp -I../../Source/WebCore/page/scrolling -I../../Source/WebCore/platform/animation -I../../Source/WebCore/platform/audio -I../../Source/WebCore/platform/calc -I../../Source/WebCore/platform/encryptedmedia -I../../Source/WebCore/platform/gamepad -I../../Source/WebCore/platform/graphics/cpu/arm -I../../Source/WebCore/platform/graphics/cpu/arm/filters -I../../Source/WebCore/platform/graphics/displaylists -I../../Source/WebCore/platform/graphics/filters -I../../Source/WebCore/platform/graphics/iso -I../../Source/WebCore/platform/mediarecorder -I../../Source/WebCore/platform/mediastream -I../../Source/WebCore/platform/mediastream/libwebrtc -I../../Source/WebCore/platform/mock -I../../Source/WebCore/platform/mock/mediasource -I../../Source/WebCore/platform/network -I../../Source/WebCore/platform/sql -I../../Source/WebCore/platform/xr -I../../Source/WebCore/plugins -I../../Source/WebCore/rendering -I../../Source/WebCore/rendering/line -I../../Source/WebCore/rendering/mathml -I../../Source/WebCore/rendering/style -I../../Source/WebCore/rendering/svg -I../../Source/WebCore/rendering/updating -I../../Source/WebCore/replay -I../../Source/WebCore/storage -I../../Source/WebCore/style -I../../Source/WebCore/svg -I../../Source/WebCore/svg/animation -I../../Source/WebCore/svg/graphics -I../../Source/WebCore/svg/graphics/filters -I../../Source/WebCore/svg/properties -I../../Source/WebCore/websockets -I../../Source/WebCore/workers -I../../Source/WebCore/workers/service -I../../Source/WebCore/workers/service/context -I../../Source/WebCore/workers/service/server -I../../Source/WebCore/worklets -I../../Source/WebCore/xml -I../../Source/WebCore/xml/parser -I../../Source/WebCore/Modules/gamepad -I../../Source/WebCore/platform/image-decoders -I../../Source/WebCore/platform/image-decoders/avif -I../../Source/WebCore/platform/image-decoders/bmp -I../../Source/WebCore/platform/image-decoders/gif -I../../Source/WebCore/platform/image-decoders/ico -I../../Source/WebCore/platform/image-decoders/jpeg -I../../Source/WebCore/platform/image-decoders/jpeg2000 -I../../Source/WebCore/platform/image-decoders/png -I../../Source/WebCore/platform/image-decoders/webp -IJavaScriptCore/Headers -IJavaScriptCore/PrivateHeaders -IWTF/Headers -IPAL/Headers -isystem /packages/libxml2_x86-2.9.12-1/.self/develop/headers/x86/libxml2 -isystem /system/develop/headers/private/netservices -march=i686 -ffunction-sections -fdata-sections -fdiagnostics-color=always -Wextra -Wall -mfpmath=sse -msse2 -Wno-expansion-to-defined -Wno-noexcept-type -Wno-psabi -Wno-misleading-indentation -Wno-maybe-uninitialized -Wwrite-strings -Wundef -Wpointer-arith -Wmissing-format-attribute -Wformat-security -Wcast-align -Wno-tautological-compare  -fno-strict-aliasing -fno-exceptions -fno-rtti -O3 -DNDEBUG -frtti   -iquote /boot/home/haikuwebkit-612.1.24/haikuwebkit-haiku-612.1.24/Source/WebCore/css -iquote /boot/home/haikuwebkit-612.1.24/haikuwebkit-haiku-612.1.24/Source/WebCore/dom -iquote /boot/home/haikuwebkit-612.1.24/haikuwebkit-haiku-612.1.24/Source/WebCore/fileapi -iquote /boot/home/haikuwebkit-612.1.24/haikuwebkit-haiku-612.1.24/Source/WebCore/platform -iquote /boot/home/haikuwebkit-612.1.24/haikuwebkit-haiku-612.1.24/Source/WebCore/platform/graphics -iquote /boot/home/haikuwebkit-612.1.24/haikuwebkit-haiku-612.1.24/Source/WebCore/platform/graphics/transforms -iquote /boot/home/haikuwebkit-612.1.24/haikuwebkit-haiku-612.1.24/Source/WebCore/platform/text -iquote /boot/home/haikuwebkit-612.1.24/haikuwebkit-haiku-612.1.24/Source/WebCore/rendering/shapes -fno-tree-sra -std=c++17 -MD -MT Source/WebCore/CMakeFiles/WebCore.dir/platform/haiku/ScrollbarThemeHaiku.cpp.o -MF Source/WebCore/CMakeFiles/WebCore.dir/platform/haiku/ScrollbarThemeHaiku.cpp.o.d -o Source/WebCore/CMakeFiles/WebCore.dir/platform/haiku/ScrollbarThemeHaiku.cpp.o -c ../../Source/WebCore/platform/haiku/ScrollbarThemeHaiku.cpp
In file included from ../../Source/WebCore/platform/haiku/ScrollbarThemeHaiku.cpp:29:
../../Source/WebCore/platform/haiku/ScrollbarThemeHaiku.h:54:10: error: 'void WebCore::ScrollbarThemeHaiku::paintScrollCorner(WebCore::GraphicsContext&, const WebCore::IntRect&)' marked 'override', but does not override
     void paintScrollCorner(GraphicsContext&, const IntRect&t) override;
          ^~~~~~~~~~~~~~~~~
../../Source/WebCore/platform/haiku/ScrollbarThemeHaiku.cpp: In member function 'virtual int WebCore::ScrollbarThemeHaiku::scrollbarThickness(WebCore::ScrollbarControlSize, WebCore::ScrollbarExpansionState)':
../../Source/WebCore/platform/haiku/ScrollbarThemeHaiku.cpp:66:66: warning: unused parameter 'controlSize' [-Wunused-parameter]
 int ScrollbarThemeHaiku::scrollbarThickness(ScrollbarControlSize controlSize, ScrollbarExpansionState)

[pulkomandy]

Please do not open bugs for versions of webkit that you created yourself and don't exist anywhere else. This does not help anyone.

This happens because something changed in WebKit and HaikuWebKit code needs to be adjusted.