Opened 3 years ago

Closed 3 years ago

#17359 closed bug (invalid)

Improper text display on command help text

Reported by: bitigchi Owned by: nobody
Priority: normal Milestone: Unscheduled
Component: Kits/Package Kit Version: R1/beta3
Keywords: Cc:
Blocked By: Blocking:
Platform: All

Description

Changes submitted in this commit[1] does not seem to be related with the coding style line limit and seem to break proper text display in a 80-column terminal window, causing extra lines.

As someone who uses and translates command line applications a lot, software that does not honour the 80-column text display looks unprofessional. This is true when static text doesn’t display properly.

Ideally, this commit should be reverted, restoring previous text display.

[1] https://git.haiku-os.org/haiku/commit/?id=04a7f3ede087acd15a50e423378b2c93c1446e1d

Change History (2)

comment:1 by nephele, 3 years ago

The limit (for our own source) was changed to 100 colomns, I'm not sure if this should apply to the terminal aswell, but if it does we should probably change the default Terminal sizes instead?

comment:2 by pulkomandy, 3 years ago

Resolution: invalid
Status: newclosed

This commit does not change anything to the output of the command. It removes line breaks that are outside strings, and were used to re-wrap the 80 columns text to fit in less columns because the sourcecode has extra indentation. The command output is the same as before and still fits in 80 columns. It is just a lot more easy to read in the sourcecode now.

If you check carefully you will see that no \n was added, removed or moved. These are what define where linebreaks end up in the final string.

Note: See TracTickets for help on using tickets.