Opened 3 years ago
Closed 3 years ago
#17399 closed bug (fixed)
Build Error MacOS 11.6 x86_64
Reported by: | m.tanay | Owned by: | nobody |
---|---|---|---|
Priority: | normal | Milestone: | R1/beta4 |
Component: | Build System | Version: | R1/beta3 |
Keywords: | Cc: | ||
Blocked By: | Blocking: | ||
Platform: | x86-64 |
Description
When trying to build from source I encountered the following errors:
- ../src/build/libgnuregex/regex.c:4924:5: error: implicit declaration of function 'free' is
invalid in C99 [-Werror,-Wimplicit-function-declaration]
free (preg->buffer);
- ../src/build/libgnuregex/regex.c:2784:11: error: implicitly declaring library function
'abort' with type 'void (void) attribute((noreturn))' [-Werror,-Wimplicit-function-declaration]
abort (); /* We have listed all the cases. */
Both the errors were in this file: https://github.com/haiku/haiku/blob/master/src/build/libgnuregex/regex.c
Possible Fix: I got the error resolved by replacing lines 66-71 in the above file with "#include <stdlib.h>" STDC_HEADERS is not needed as per the following article: https://www.gnu.org/software/autoconf/manual/autoconf-2.67/html_node/Particular-Headers.html
I would like to submit a patch if this bug is confirmed and my solution is accepted. Thank you
Change History (2)
comment:1 by , 3 years ago
comment:2 by , 3 years ago
Milestone: | Unscheduled → R1/beta4 |
---|---|
Resolution: | → fixed |
Status: | new → closed |
Applied in hrev56025
In my own testing this patch fixes this build error on macOS.