Opened 12 years ago

Closed 10 years ago

#1740 closed enhancement (fixed)

[Trac] Include attachment indicator in email notifications

Reported by: umccullough Owned by: nielx
Priority: normal Milestone: Trac 0.11
Component: Website/Trac Version:
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

Currently there there appears to be no email indicator when an attachment is added to a ticket. This causes some people to miss when an attachment is added to a ticket unless a comment stating such is also added.

Would be nice if attachments and their names are also mentioned in the email notifications.

Attachments (3)

test.txt (42 bytes ) - added by umccullough 12 years ago.
test2.txt (48 bytes ) - added by umccullough 11 years ago.
Another test to ensure that it's fixed (since I was never able to test before)
USB3_sample2_definitions.diff (30.5 KB ) - added by nielx 10 years ago.
Test attachment

Download all attachments as: .zip

Change History (18)

comment:1 by nielx, 12 years ago

Owner: changed from gavin to nielx

Looking into this ...

comment:2 by nielx, 12 years ago

Milestone: R1Trac 0.11
Resolution: fixed
Status: newclosed
Version: R1 development

Okay, found something.

http://trac.edgewall.org/ticket/2259

There is a patch attached, which I will commit to our locally modified Trac 0.11. Marking it as fixed, since this will be included when Trac 0.11 goes live.

comment:3 by umccullough, 12 years ago

Nice!

Maybe the reason nobody has committed it to Trac yet is because they didn't notice a patch has been attached to that ticket ;)

comment:4 by nielx, 12 years ago

Well, the official explanation is that it is not generic enough. Anyway, worksforme now :-)

by umccullough, 12 years ago

Attachment: test.txt added

comment:5 by umccullough, 12 years ago

From your comment, and a quick test, this means the current Trac wasn't patched - and that you're maintaining a newer (not-yet-implemented) Trac 0.11 update where you've applied the patch already?

comment:6 by nielx, 12 years ago

Yes. There is one crucial bug in trac 0.11beta which is preventing me from using it. But it is indeed fixed in a local repository.

by umccullough, 11 years ago

Attachment: test2.txt added

Another test to ensure that it's fixed (since I was never able to test before)

comment:7 by umccullough, 11 years ago

Resolution: fixed
Status: closedreopened

Reopening as this is apparently not fixed in the new Trac 0.11RC1 now.

(Preferably fixed issues for website/trac don't get closed until they're actually available to the reporter)

comment:8 by nielx, 11 years ago

I thought I had this one nailed. Probably one of the code merges of newer Trac installations broke it. I will look into this on Thursday.

comment:9 by nielx, 11 years ago

Owner: changed from nielx to haiku-web
Status: reopenednew

Reassign to generic owner.

comment:10 by umccullough, 10 years ago

As mentioned in the edgewall ticket above, there's another solution:

http://trac-hacks.org/wiki/AnnouncerPlugin

Can we test this out?

comment:11 by pulkomandy, 10 years ago

The rss feed can be used for that. I tend to use it more than mail notifications, actually.

in reply to:  10 comment:12 by nielx, 10 years ago

Replying to umccullough:

As mentioned in the edgewall ticket above, there's another solution:

http://trac-hacks.org/wiki/AnnouncerPlugin

Can we test this out?

I am a bit cautious when it comes to modules that replace a major internal subsystem of Trac. At this point in time, I think it is reasonably safe to say that the next major version of Trac (0.12) will not fix this, but since this release should be sooner rather than later, I actually prefer to wait until the module is ported to Trac 0.12 to test it out.

comment:13 by nielx, 10 years ago

Owner: changed from haiku-web to nielx
Status: newassigned

Taking another stab at this one, as it seems it will not be in Trac 0.12.

comment:14 by nielx, 10 years ago

Implementation finished and tested on a local installation. See http://hg.haiku-os.org/trac-attachmentnotifier/

I am hoping to roll this change out soon.

by nielx, 10 years ago

Test attachment

comment:15 by nielx, 10 years ago

Resolution: fixed
Status: assignedclosed

Deployed (and tested) as of now. Please create a new bug report if you find any issues.

Note: See TracTickets for help on using tickets.