Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#17577 closed bug (fixed)

[LaunchBox] black border at the bottom

Reported by: diver Owned by: stippi
Priority: normal Milestone: Unscheduled
Component: Applications/LaunchBox Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Platform: All

Description

Looks like hrev55781 made LaunchBox draw black border at the bottom.

Attachments (1)

launchbox.jpg (13.7 KB ) - added by diver 2 years ago.

Download all attachments as: .zip

Change History (6)

by diver, 2 years ago

Attachment: launchbox.jpg added

comment:1 by pulkomandy, 2 years ago

That revision only touches DiskProbe, what is the last known working one?

comment:2 by diver, 2 years ago

Commit message says DiskProbe but it actually touches LaunchBox.

comment:3 by pulkomandy, 2 years ago

Indeed, that's confusing... :(

So this line is now drawn with the "shadow" color (and the highlight one with the "shine" color). I'm not sure how that's better than what was done before (which was based on the color of the panel background but with lighten/darken).

I think we should revert that commit.

comment:4 by pulkomandy, 2 years ago

Resolution: fixed
Status: newclosed

Reverted in hrev55873.

comment:5 by konrad, 2 years ago

The change is for dark mode. Its looks like crap in darkmode because the light tinting is too extreme. It would be better to apply this patch and change the default settings for shadow/shine color.

Last edited 2 years ago by konrad (previous) (diff)
Note: See TracTickets for help on using tickets.