WebPositive (master): crash on quit

[vidrep]

hrev55867 x86_64

HaikuWebKit 1.8.4

WebKit 614.1.3

After browsing Amazon.com website, crash on quit

Debugger report attached

[vidrep]

WebPositive crashes when closing on any webpage, not just Amazon.com Debugger log attached for latest crash(s)

[korli]

It looks like in the two reports there is a running authentication request, which probably helds a reference on the BUrlContext.

[humdinger]

I see the same thing now on hrev55874, 64bit. It only crashes for me when I do ALT+Q, not when using the window close widget.

[vidrep]

The problem is still here with HaikuWebKit 1.8.4 WebKit 614.1.20

There are noticable improvements and bug fixes in this version compared to what is currently shipped with Haiku nightly builds.

Perhaps someone can try to fix this crash before Beta 4, so we can include this improved browser build.

[tqh]

To me the reference count crash is either problem freeing BURLRequest in WebPositive or a problem in the class itself. I'd take a look at this: ​https://github.com/haiku/haiku/blob/c3abd58da6abeea0a0a2aa7d0597793c23b4a71d/src/kits/network/libnetservices/UrlRequest.cpp#L19

[tqh]

Not sure but shouldn't URLRequest destructor do more cleanup and delete it's references?

[pulkomandy]

It's complicated because of several things:

• BUrlRequest is tied to a thread, if you delete the object while the thread is running, things will crash
• Stopping a request is a complicated process and is different for different subclasses (BHttpRequest, BGopherRequest, BFileRequest, etc). In C++, it is not possible to call virtual methods from the upper class destructor (so the destructor for BUrlRequest cannot call the virtual method Stop() and have it properly stop each type of request.

So the lifecycle of requests is quite complicated. I hope that nielx's work on rewriting libnetservices will fix this eventually. Until then we could also use WebKit curl support again instead (I have recently fixed the build for that and checked that it can still load webpages, but I have not done any furhter testing.

@vidrep, the last report you attached is a completely different crash that happens when deleting WebKit font cache, I think it should be reported as a separate ticket to avoid confusion.

[tqh]

Took a stab at it: ​https://review.haiku-os.org/c/haiku/+/5486 Havn't managed to provoke a crash yet.

[tqh]

Check if hrev56296 solves this. I havn't managed to reproduce it afterwards.

(Just other things like using all mem in VM or network stalls...)

[tqh]

Vidrep reported that these crashes are now gone.