Exporting PS1 considered as a bad practice

[miqlas]

Currently Haiku exports PS1 in the /etc/profile file, and i assume it have something to do with the setarch support, however exporting the PS1 in profile breaks the zsh prompt: see the attached screenshot.

The zsh people warned me: exporting PS1 in the profile is a bad practice and they recommends to do it in the bashrc. They said it should be possible to move the logic to the bashrc without any functional change.

[pulkomandy]

In addition to setarch, this is to make the prompt green or red depending on wether the previous command succeeded.

This should be written in a way that's compatible with any POSIX shell, not just bash. Is it not? I have initially written this code with mksh, but maybe the version in Haiku was changed a bit since then.

If written in standard POSIX shell, there is no reason to not have it in /etc/profile. Any shell parsing that file should be happy with it.

[miqlas]

I found this: ​https://unix.stackexchange.com/questions/247585/to-export-or-not-to-export-bash-ps1-variable

[bipolar]

The zsh people warned me: exporting PS1 in the profile is a bad practice and they recommends to do it in the bashrc.

Doing it in the bashrc won't do much on Haiku's Terminal, as it always opens bash as a login shell (so it loads profile instead of bashrc).

[pulkomandy]

In ​https://github.com/haikuports/haikuports/commit/3d303f66fa61a7680105e8b47609b4e1abbf38d6 I have patched zsh so that it sets itself with an usable prompt by default.

Do we consider that a good enough of a fix for this issue?