Opened 5 months ago

Last modified 4 weeks ago

#17829 new enhancement

Upgrade FFmpeg to 4.4 (or 5)

Reported by: waddlesplash Owned by: pulkomandy
Priority: normal Milestone: R1/beta5
Component: Audio & Video/Codecs Version: R1/beta3
Keywords: Cc:
Blocked By: Blocking:
Platform: All

Description

It has ABI differences with 4.2 and thus we must rebuild the media-addon against it immediately after upgrading.

Change History (9)

comment:1 by waddlesplash, 5 months ago

Type: bugtask

comment:2 by pulkomandy, 5 months ago

Should this really be a beta4 blocker? We're already going to have (once again) more than 1 year between releases, maybe it's time to stop adding new things to the beta4 milestone and have this in beta5 instead?

What's the reasoning for having it here?

comment:3 by waddlesplash, 5 months ago

Note I recorded this as a "task"; I think the only thing required here is that we just rebuild the media-addon against the new FFmpeg. I don't think it will take any amount of time.

comment:4 by waddlesplash, 5 months ago

We're still on a version of FFmpeg from 2019, is the main motivation for changing this.

comment:5 by pulkomandy, 5 months ago

Ok, I guess I'm a bit worried about the regressions it could cause in media encoding/decoding if we need to adjust how we use the APIs. It would be annoying to further delay the release because of that. It really depends how much the API changed.

In general it's the kind of thing I'd rather do at the start and not at the end of a release cycle.

in reply to:  5 comment:6 by jackburton, 5 months ago

Replying to pulkomandy:

Ok, I guess I'm a bit worried about the regressions it could cause in media encoding/decoding if we need to adjust how we use the APIs. It would be annoying to further delay the release because of that. It really depends how much the API changed.

In general it's the kind of thing I'd rather do at the start and not at the end of a release cycle.

I agree, especially since we already have various issues in media encoding/decoding. No need to introduce new, unknown ones.

comment:7 by waddlesplash, 5 months ago

Based on reading the changelog, I think the changes are purely in terms of ABI? I agree if we have to make anything but trivial source changes then we should do this later.

comment:8 by bruno, 2 months ago

If you do this later, will you move it to beta-5 or close the ticket for now?

comment:9 by waddlesplash, 4 weeks ago

Component: Audio & VideoAudio & Video/Codecs
Milestone: R1/beta4R1/beta5
Owner: changed from nobody to pulkomandy
Priority: blockernormal
Summary: Upgrade FFmpeg to 4.4Upgrade FFmpeg to 4.4 (or 5)
Type: taskenhancement

We now use a more current release of 4.2, I think this can be deferred at this point and we can jump straight to 5 when ready.

Note: See TracTickets for help on using tickets.