haikuwebkit: ImageBufferHaikuSurfaceBackend code fails during build

[cocobean]

x64 build fails with: const marked override, but does not overrride

​https://github.com/haiku/haikuwebkit/blob/haiku/Source/WebCore/platform/graphics/haiku/ImageBufferHaikuSurfaceBackend.h

Lines: 52, 53

    String toDataURL(const String& mimeType, std::optional<double> quality, PreserveResolution) const override;
    Vector<uint8_t> toData(const String& mimeType, std::optional<double> quality) const override;

Tested: HaikuWebKit 1.8.4 WebKit 614.1.20 on hrev56315 x64 Ref: ​https://github.com/haiku/haikuwebkit/commit/c9c126f36feae66940ccbaa5892d1847b58585f4

[pulkomandy]

The methods come from ​https://github.com/haiku/haikuwebkit/blob/haiku/Source/WebCore/platform/graphics/ImageBufferBackend.h#L122 and our implementation overrides them, as far as I can see, with the same prototype.

Am I missing something?

[korli]

override is useless when overriding pure virtual methods as the compiler already would check their existence.

[pulkomandy]

override warns you if the method in the upstream class was changed and you forgot to update it in the derived one. This happens regularly in WebKit and without the override keyword it was very hard to find these problems in the Haiku version, now it is easy because the compiler does it.

It is mandatory in WebKit coding guidelines.

Anyway, I still don't see the problem here, the method does override one from the parent class, right? So there shouldn't be a problem? I will check again at home but the code compiled for me before I pushed it, unless I forgot to push some files I don't see how there can be an error here?

[cocobean]

Wiped directory and rebuilt. Native build was successful and works. Only affects recent versions of ImageBufferBackend code > WebKit 614.1.20.1. Please close this ticket.