HaikuDepot crashes regularly when user addins are disabled

[Uityyy]

HaikuDepot crashes with a segment violation in function BBitmap:Bounds(BBitmap) when it attempts to render information on certain packages while user addons are disabled.

Steps to reproduce:

• Boot Haiku r1beta3 with the shift key held down and turn on "Disable user addos" in the Safemode Options.
• Open HaikuDepot.

It crashes part way through loading the All packages list. You can also crash it by selecting Featured packages>Games. Only certain packages trigger this crash. Under Featured packages>Audio the crash does not occur until you scroll down.

As of 2022-08-10, BeLife can be used as an example of a package with the "right" image/metadata to trigger this crash.

I have reproduced this directly from the r1beta3 x86 install ISO in VirtualBox and on a real-hardware install after running pkgman full-sync but have not checked other architectures.

[Uityyy]

Stack trace from real hardware

[Starcrasher]

Please, check with a nightly iso. I think that this bug has been corrected already there. When disabling user-addons it was disabling also the system ones. IIRC this was causing problem with StyleEdit as well.

[Starcrasher]

Not already fixed but, duplicate of 17698

[Uityyy]

I was thinking the solution would just be for HaikuDepot to have a fallback better than "Segmentation violation" whan an image couldn't be properly parsed. That's probably good practice even if there aren't known instances of unparsable data, but if #17698 is resolved in a way that makes everything parse even with addons disabled, that would make the issue moot.

[apl-haiku]

This seems to happen on the nightly too -- will try to take a look soon.

[waddlesplash]

Fixed in hrev56393.