Screen prefs crash

[humdinger]

This is hrev56368, 64bit

Opening Screen preferences crashes:

state: Exception (Segment violation)

Frame		IP			Function Name
-----------------------------------------------
0x7f478147bc80	0x49a4a8c444	strlcpy + 0x34 
    Disassembly:
        strlcpy:
        0x00000049a4a8c410:           4889f9  mov %rdi, %rcx
        0x00000049a4a8c413:           4889f7  mov %rsi, %rdi
        0x00000049a4a8c416:           4885d2  test %rdx, %rdx
        0x00000049a4a8c419:             7455  jz 0xa4a8c470
        0x00000049a4a8c41b:               55  push %rbp
        0x00000049a4a8c41c:           4989f0  mov %rsi, %r8
        0x00000049a4a8c41f:           4889ce  mov %rcx, %rsi
        0x00000049a4a8c422:           4889e5  mov %rsp, %rbp
        0x00000049a4a8c425:               53  push %rbx
        0x00000049a4a8c426:             31db  xor %ebx, %ebx
        0x00000049a4a8c428:         4883ec08  sub $0x8, %rsp
        0x00000049a4a8c42c:         4883ea01  sub $0x1, %rdx
        0x00000049a4a8c430:             7512  jnz 0xa4a8c444
        0x00000049a4a8c432:             eb20  jmp 0x49a4a8c454
        0x00000049a4a8c434:         0f1f4000  nop (%rax)
        0x00000049a4a8c438:           880419  mov %al, (%rcx,%rbx)
        0x00000049a4a8c43b:         4883c301  add $0x1, %rbx
        0x00000049a4a8c43f:           4839d3  cmp %rdx, %rbx
        0x00000049a4a8c442:             7434  jz 0xa4a8c478
        0x00000049a4a8c444:         0fb6041f  movzx (%rdi,%rbx), %eax <--

    Frame memory:
        [0x7f478147bc60]  ..........G.G...   00 00 00 00 00 00 00 00 10 be 47 81 47 7f 00 00
        [0x7f478147bc70]  ..G.G....(i:....   e0 bc 47 81 47 7f 00 00 99 28 69 3a 8a 00 00 00
0x7f478147bcf0	0x8a3a692894	ScreenMode::GetMonitorInfo(monitor_info&, float*) + 0xd4 
0x7f478147c000	0x8a3a6963b7	ScreenWindow::ScreenWindow(ScreenSettings*) + 0xf87 
0x7f478147c030	0x8a3a691d34	ScreenApplication::ScreenApplication() + 0x54 
0x7f478147c1d0	0x8a3a68f7e9	main + 0x19 
0x7f478147c200	0x8a3a68fa9a	_start + 0x3a 
0x7f478147c230	0x143df277a93	runtime_loader + 0x103 
00000000	0x7fff2d33a258	commpage_thread_exit + 0 

Complete log attached.

[jackburton]

There are chances this is fixed in hrev56371

[jackburton]

I still can't test on real hardware, but change 5571 is more likely to fix the crash

[jackburton]

Managed to test hrev56376 on real hardware : I think I hit a case which could certainly crash before hrev56374 (vendor not found in the list), and confirm it doesn't crash.

[humdinger]

Confirmed fixed here as well. Thanks!