Opened 2 years ago

Closed 2 years ago

#17951 closed bug (fixed)

[AboutSystem] doesn't show Generation number for Intel CPUs

Reported by: diver Owned by: nobody
Priority: normal Milestone: R1/beta4
Component: Applications/AboutSystem Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Platform: All

Description

hrev56413, VMware Workstation.

Attachments (2)

aboutsystem.png​ (40.5 KB ) - added by diver 2 years ago.
aboutsystem2.png​ (35.6 KB ) - added by diver 2 years ago.

Download all attachments as: .zip

Change History (8)

by diver, 2 years ago

Attachment: aboutsystem.png​ added

comment:1 by korli, 2 years ago

The code assumes the vendor comes first and ignores it: ​https://github.com/haiku/haiku/blob/master/headers/private/shared/cpu_type.h#L52 The first and second word should be checked.

by diver, 2 years ago

Attachment: aboutsystem2.png​ added

comment:3 by diver, 2 years ago

Seems to be fixed. Do we want to keeps registered trademark (®) symbol?

comment:4 by korli, 2 years ago

No regression, the registered trademark symbol isn't part of the vendor names: ​https://github.com/haiku/haiku/blob/master/headers/private/shared/cpu_type.h#L175

comment:5 by diver, 2 years ago

Thanks for the fix! :)

comment:6 by korli, 2 years ago

Milestone: Unscheduled → R1/beta4
Resolution: → fixed
Status: new → closed

Thanks for the test! Applied in hrev56464

Note: See TracTickets for help on using tickets.