Webpositive (master) - crash on quit after viewing Google image

[vidrep]

hrev56490 x86_64

HaikuWebKit 1.8.4 WebKit 615.1.4

After viewing a Google image WebPositive crashes on quit.

Debug report attached

[madmax]

I can't seem to get it with WebPositive, but I do almost always with HaikuLauncher. In my case the leaked references are for ​the static context in platformSession.

[tqh]

Sounds similar to the WebPositive fix I did: ​https://github.com/haiku/haiku/commit/f28e05bce54338fe462faef9e4e0d3a0efebb425

[pulkomandy]

I am building the 1.9.0 release with curl instead of netservices API, so that code is not used. That should be ok for the beta 4 version.

How did you identify which allocation was problematic? I could not find it.

[pulkomandy]

Also isn't there already a default URL context in the services kit? Shouldn't we use that one instead?

[madmax]

How did you identify which allocation was problematic? I could not find it.

No analysis, so I don't even know where the references are aquired and never released. I get easily confused with simple pointers and references, so if you add BReferences to the mix...

So brute force. I got obsessive, added a field to BReferenceable (and BReference, for good measure), filled it in every constructor and added it to the log. That showed it to be a BUrlContext, and then I did something similar to find out which instantiation it was.

Also isn't there already a default URL context in the services kit?

There seems to be one in UrlRequest.

[madmax]

This one should be fixed by the change to curl, or ​fe216a33 if your go back to netservices. I have not seen the crash again, but I only got it with HaikuLauncher, not with WebPositive as in the report.