Weird button scaling in decorator

[Starcrasher]

Trying the new Arpaint version, I noticed that 'Tool settings' window has a strange bug in decorator tab.

The button to close the window is of the right size when the window is inactive but too small when the window is active. It seems to be of the right size when you click on it to close the window. It happens only with this window whatever the decorator used.

Perhaps something that shouldn't have been scaled? But, so far, I didn't notice that in another program.

This is on nightly x64 hrev56511 This bug has also been reported as ​Artpaint issue 290

[Starcrasher]

Inactive window

[Starcrasher]

active window

[pulkomandy]

Does it switch between different window "looks" at runtime? There is one specific "look" flag that's supposed to have a smaller titlebar.

[humdinger]

Yes, the feel of windows can be from the ArtPaint settings at runtime. This is the code: ​https://github.com/HaikuArchives/ArtPaint/blob/master/artpaint/tools/ToolSetupWindow.cpp

The weird thing is that the close button size changes when the normal-look window switches between active/inactive...

[Starcrasher]

Windows with a smaller title bar (i.e. MediaPlayer settings) are not stackable, are they?

I notice that if you move Artpaint's 'Tool Settings' window over another to stack it with another, the button takes the right size and keep it. Even if you don't release the mouse to stack the windows.

[dsizzle]

I finally figured out why it's only happening with that one window, and perhaps this is a clue: the window feel is being reset in the ToolSetupWindow constructor *after* BWindow::Show() is called. If I move the BWindow::Show() so that the window feel is set first, the issue goes away.

[pulkomandy]

Could it simply be a missing call to Invalidate() (or whatever the equivalent is for decorators) in case of a look change between the small titled and the normal titled look?