Running find in NTFS directory panics in fs_read_dir() at reclen <= bufferRemaining

[nyanpasu64]

Tried booting haiku-master-hrev56554-x86_64-anyboot.iso, mounting my Windows 7 disk (which passes Windows 7 chkdsk), then opening a shell, cd /WINDOWS followed by find. After around 10 seconds it reliably crashes at:

PANIC: ASSERT FAILED (...fs_ops_support.h:21): reclen <= bufferRemaining

This corresponds to ​https://github.com/haiku/haiku/blob/b2c77ad27a867a71e20fcde975bc5d06cd22e968/headers/private/file_systems/fs_ops_support.h#L21.

This function was inlined into ntfs's fs_read_dir: ​https://github.com/haiku/haiku/blob/3c1cf7b29467994b4719767eacc75fecf1caf12f/src/add-ons/kernel/file_systems/ntfs/kernel_interface.cpp#L1238

I'm guessing there's a logic error of some sort in this function, possibly linked to long folders. I don't know how to use KDL though, to debug what folder was being read, and I don't currently know what on-disk and in-memory types and values are present, the intended invariants, and what incorrect assumption led to this crash.

[nyanpasu64]

Photo of KDL opened to the NTFS crash

[waddlesplash]

Please see if hrev56557 fixes the problem.

[nyanpasu64]

Tried haiku-master-hrev56560-x86_64-anyboot.iso (there was no hrev56557 .iso) and I no longer get a crash when running find in my Windows install. I haven't noticed any other funny behavior, though I did not test NTFS or the rest of Haiku deeply.

[waddlesplash]

Thanks for testing!