Opened 2 years ago

Closed 2 years ago

#18159 closed enhancement (invalid)

Add AMD i2c support to i2c-piix4

Reported by: kallisti5 Owned by: nobody
Priority: low Milestone: Unscheduled
Component: Drivers Version: R1/Development
Keywords: i2c ryzen Cc:
Blocked By: Blocking:
Platform: x86-64

Description

AMD's common i2c controller (1022:790b) could be added to our i2c-piix4 driver with low/medium effort.

Linux handles AMD in via drivers/i2c/busses/i2c-piix4.c (PCI_DEVICE_ID_AMD_KERNCZ_SMBUS).

We really need some quirk checks (mmio mostly), and to adjust addresses slightly based on those quirk checks.

Change History (4)

comment:1 by korli, 2 years ago

"our i2c-piix4 driver", dunno what you mean.

comment:2 by kallisti5, 2 years ago

https://cgit.haiku-os.org/haiku/tree/src/add-ons/kernel/busses/i2c/pch/pch_i2c_pci.cpp

Sorry, should have called it pch. That's almost 1:1 the Linux i2c-piix4 driver. (same PCIID's, etc)

Last edited 2 years ago by kallisti5 (previous) (diff)

comment:3 by korli, 2 years ago

I don't see the same ids...

The Linux driver for pch is intel-lpss

comment:4 by kallisti5, 2 years ago

Resolution: invalid
Status: newclosed

Ack, you're right. We essentially need a new piix4 i2c/smbus driver to cover anything AMD. Lame.

Note: See TracTickets for help on using tickets.