Opened 11 years ago

Closed 5 years ago

#1817 closed bug (fixed)

Tracker preferences / Ask before delete does not work

Reported by: hma Owned by: axeld
Priority: normal Milestone: R1
Component: Applications/Tracker Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: yes Platform: All

Description

Tracker does not show conformation dialog for moving files to trash or emptying trash.

In Tracker Preferences / Trash there is a checked check box "Ask before delete", but no asking is done.

I would also suggest following usability improvements:

"Don't move files to trash" checkbox does not inform the user what is the alternative. Using radio buttons and spelling out the alternative would be better. Like this:

---When files are moved to trash------------- | | (*) Keep files in Trashcan. | ( ) Delete files permanently.


This way the setting is more conceptually compatible with Tracker's "Move to trash" command, and unwise setting sounds bad. :)

It is unclear if "Ask before delete" means getting confirmation dialog before moving item into trash or when trashcan is emptied. I would suggest having a separate checkbox for both, so that experts are free to shoot themselves in the foot and common people do not screw up when accidentally pressing "Delete" key. Like so:

--Ask before... ------------------------ | | [x] moving files into trash. | [x] deleting files permanently.


Attachments (1)

tracker-delete-options.patch (10.1 KB) - added by scgtrp 7 years ago.
A patch to split the 'ask on delete' option into 'ask on permanent delete' and 'ask on move to trash'.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 9 years ago by diver

Component: User InterfaceApplications/Tracker
Owner: changed from stippi to axeld
Summary: Tracker Trash preferences / Ask before delete does not workTracker preferences / Ask before delete does not work
Version: R1/pre-alpha1R1/Development

Still here in hrev38756

Changed 7 years ago by scgtrp

A patch to split the 'ask on delete' option into 'ask on permanent delete' and 'ask on move to trash'.

comment:2 Changed 7 years ago by scgtrp

Has a Patch: set

comment:3 Changed 6 years ago by mmadia

Is this patch obsolete due to hrev45265? Is it worthwhile to have "Ask before emptying Trash" (or something similarly named)?

comment:4 Changed 5 years ago by un_spacyar

I check hrev47223, and no Trash settings in Preferences/Tracker.

Is this ticket still valid, or can be closed?

comment:5 Changed 5 years ago by humdinger

Resolution: fixed
Status: newclosed

Right, we can close this ticket. WRT mmadia's old comment, I think the command to have the Trash emptied being in a context menu, it is sufficiently protected against accidental invokation. An additional alert "Do you really want to empty the Trash?" is more annoying than helpful.

Note: See TracTickets for help on using tickets.