Change #5667 seems to break remote_disk driver used by pxe/netboot.

[sirocyl]

(Hey, just touching some less-used build paths and encountered this - probably a very low-priority one here, but I figure I'd make a note about it.)

Building with the string:

jam -q -j2 haiku-netboot.tgz

it seems to cough up a few errors on building remote_disk.cpp:

C++ objects/haiku/x86_64/release/add-ons/kernel/drivers/disk/virtual/remote_disk/RemoteDisk.o 
../src/add-ons/kernel/drivers/disk/virtual/remote_disk/remote_disk.cpp: In function 'status_t remote_disk_control(void*, uint32, void*, size_t)':
../src/add-ons/kernel/drivers/disk/virtual/remote_disk/remote_disk.cpp:255:29: error: 'buffer' was not declared in this scope
  255 |                         if (buffer == NULL || length > sizeof(device_geometry))
      |                             ^~~~~~
../src/add-ons/kernel/drivers/disk/virtual/remote_disk/remote_disk.cpp:255:47: error: 'length' was not declared in this scope
  255 |                         if (buffer == NULL || length > sizeof(device_geometry))
      |                                               ^~~~~~
../src/add-ons/kernel/drivers/disk/virtual/remote_disk/remote_disk.cpp:259:44: error: 'buffer' was not declared in this scope
  259 |                         return user_memcpy(buffer, &geometry, length);
      |                                            ^~~~~~
../src/add-ons/kernel/drivers/disk/virtual/remote_disk/remote_disk.cpp:259:63: error: 'length' was not declared in this scope
  259 |                         return user_memcpy(buffer, &geometry, length);
      |                                                               ^~~~~~

These changes seem to originate with ​5667: add physical_block_size field where applicable.

This change ​landed in between ​hrev56465 and ​hrev56466.

Unless I'm doing something wrong, this seems to block netboot images from being built.

Built:

• from near-latest revision of Haiku x86_64, R1/beta4 hrev56578+70;
• building haiku hrev56781 x86_64
• with buildtools btrev43197

which are the latest source checkouts as of 20230218.

Bisect:

• Building with the jam string above after a git checkout hrev56465 seems to work.
• Building with the same jam string, after a git checkout hrev56466 fails with the same error above.

(NB: Builds for the netboot image should be done after building another more complete target such as @minimum-raw or @nightly-raw, or it will complain of missing libraries. That is probably another, unrelated issue in the dependencies in the build system.)

[waddlesplash]

Fixed in hrev56784.