In Dark mode in Haiku API docs parts of source are invisible

[tclaus]

Parts of the code samples are unreadable in dark mode. Black text on dark gray background is quite invisible.

[tclaus]

Screenshot on docs/api from macOS Ventura on Safari browser

[nephele]

Hi tclaus, can you open the web inspecter to let me know what the css class and style of that text is?

[tclaus]

To be more precise: I found this in the API Documentation page: ​https://www.haiku-os.org/docs/api/layout_intro.html

The text has no css style, or lets say the default text as it has no assigned class:

<div class="line">
<a class="code hl_class" href="classBGroupLayout.html">BGroupLayout</a>
* group = 
<span class="keyword">new</span> 
<a class="code hl_class" href="classBGroupLayout.html">BGroupLayout</a>
(
<a class="code hl_enumvalue" href="InterfaceDefs_8h.html#ac5fc6e200c34376449ba20a234061eb4a01c35140b008aea2cb9eca52ecf7cd4e">B_VERTICAL</a>);</div>

Here the "* group =" - section don't change its color in dark mode.

The CSS-Styles I found are: book.css, doxygen.css, search.css and tabs.css - not sure if this is what you requested?

Buy the way, the images HaikuDark.svg and LeafDark.png are failed to found.

​https://www.haiku-os.org/images/HaikuDark.svg

​https://www.haiku-os.org/images/LeafDark.png

[nephele]

I ment opening the web inspector of safari, selecting the text and seeing where it computed the color from. (with a screenshot).

I can do this alternativly but only later :)

For the images please open a seperate ticket.

[madmax]

div.fragment. We have color: black in book.css. doxygen.css uses var(--fragment-foreground-color), which is #C9D1D9 in dark mode, if I'm reading it correctly.

[nephele]

This should be --CanvasText, but since I am using CanvasText as it's value I'll prepare a patch to remove the variable in favor of using CanvasText directly. (also for the userguide) same for --CanvasBackground

[nephele]

Proposed fix ​https://review.haiku-os.org/c/haiku/+/6184

[nielx]

@tclaus: could you review whether the problem is fixed now?

[tclaus]

Darkmode view after the fix

[tclaus]

Now it looks nice in the dark mode. (Safari 16.4 on MacOS) I have added a new attachment with the current look.

Ticket can be closed.