GPF in LocaleDataBridge running mgba

[korli]

Trying to run mgba from haikuports with locale enabled triggers a GPF in BPrivate::Libroot::LocaleNumericDataBridge::LocaleNumericDataBridge(bool)

To reproduce, remove the workaround patch for mgba at haikuports, build, install the package, run mgba-qt in the terminal.

This looks like a regression, the same version of mgba worked without patching begin 2022.

​https://github.com/haikuports/haikuports/blob/master/games-emulation/mgba/patches/mgba-0.9.3.patchset

[korli]

crash report

[waddlesplash]

rdx is 0x0064006e00690053, that looks invalid. Uninitialized memory?

Actually it looks like UTF-16: <00>d<00>n<00>i<00>S

[korli]

Seems to happen by a memcpy: ​https://cgit.haiku-os.org/haiku/tree/src/system/libroot/posix/locale/LocaleDataBridge.cpp#n95

[waddlesplash]

#18344 was just reported, it looks pretty similar, also crashing in LocaleNumericDataBridge with a bogus pointer.

[waddlesplash]

Almost certainly fixed by hrev56941, but please test just in case.

[korli]

indeed. thanks!