burp sends Haiku into KDL

[begasus]

Checking the latest burp version against the current librsync and the latest librsync sends Haiku in KDL. Attatching 2 pictures from the KDL.

To reproduce with the latest burp, in Terminal (first tab):

burp -c /boot/system/settings/burp/burp-server.conf -F

In a second tab just type "burp" to launch the client.

PR for latest burp can be found here: ​https://github.com/haikuports/haikuports/pull/8553

[begasus]

First KDL after starting the client

[begasus]

Ran sc in KDL

[waddlesplash]

Does it happen on x86_64?

[Begasus]

This was tested on R1B4 32bit.

With the changes in the recent nightly there is no KDL anymore.

> burp
2023-05-02 13:15:11: burp[8437] Could not find ssl_cert /packages/burp_x86-3.1.4-1/.self/settings/burp/ssl_cert-client.pem: No such file or directory
2023-05-02 13:15:11: burp[8437] Could not find ssl_key /packages/burp_x86-3.1.4-1/.self/settings/burp/ssl_cert-client.key: No such file or directory
2023-05-02 13:15:11: burp[8437] Connecting to localhost:4971
2023-05-02 13:15:11: burp[8437] auth ok
2023-05-02 13:15:11: burp[8437] Server version: 3.1.4
2023-05-02 13:15:11: burp[8437] Server will sign a certificate request
2023-05-02 13:15:11: burp[8437] Generating SSL key and certificate signing request
2023-05-02 13:15:11: burp[8437] Running '/packages/burp_x86-3.1.4-1/.self/bin/burp_ca --key --keypath /packages/burp_x86-3.1.4-1/.self/settings/burp/ssl_cert-client.key --request --requestpath /packages/burp_x86-3.1.4-1/.self/settings/burp/CA-client/testclient.csr --name testclient'
hostname: invalid option -- 'f'
generating key testclient: /packages/burp_x86-3.1.4-1/.self/settings/burp/ssl_cert-client.key
Try 'hostname --help' for more information.
Generating RSA private key, 2048 bit long modulus (2 primes)
..............................................................................+++++
.................................................+++++
e is 65537 (0x010001)
generating request testclient
2023-05-02 13:15:12: burp[8437] /packages/burp_x86-3.1.4-1/.self/bin/burp_ca returned: 0
2023-05-02 13:15:12: burp[8437] Sent /packages/burp_x86-3.1.4-1/.self/settings/burp/CA-client/testclient.csr
2023-05-02 13:15:13: burp[8437] Received: /packages/burp_x86-3.1.4-1/.self/settings/burp/ssl_cert-client.pem.8437
2023-05-02 13:15:13: burp[8437] Received: /packages/burp_x86-3.1.4-1/.self/settings/burp/ssl_cert_ca.pem.8437
2023-05-02 13:15:13: burp[8437] Re-opening connection to localhost:4971
2023-05-02 13:15:18: burp[8437] Connecting to localhost:4971
2023-05-02 13:15:18: burp[8437] auth ok
2023-05-02 13:15:18: burp[8437] Server version: 3.1.4
2023-05-02 13:15:18: burp[8437] nocsr ok
2023-05-02 13:15:18: burp[8437] SSL is using cipher: TLS_AES_256_GCM_SHA384  TLSv1.3 Kx=any      Au=any  Enc=AESGCM(256) Mac=AEAD

2023-05-02 13:15:18: burp[8437] extra_comms_begin ok:autoupgrade:incexc:orig_client:uname:failover:vss_restore:regex_icase:counters_json:msg:forceproto=1:rshash=blake2:seed:
no backups
2023-05-02 13:15:18: burp[8437] List finished ok

[waddlesplash]

I suspect hrev56959 fixed this problem, it should get backported to the release probably.

[waddlesplash]

Backported to r1beta4 as ​https://git.haiku-os.org/haiku/commit/?h=r1beta4&id=b2dcaeb58560479238a6d9cae1efad7d98134f52. Please retest with a beta4 update tomorrow and see if this is also fixed there.

[begasus]

Latest backport confirmed working fine, no KDL anymore, thanks!

[waddlesplash]

Very good!