Tab close buttons should be aligned to left, not right

[bitigchi]

(Assuming this is related to TabView)

Haiku window close control is located on the left side of the window title tab. However, in applications like Web+, the close button is right-aligned. This looks like a mismatch. All close buttons on the interface should use the same alignment as the window tabs.

[humdinger]

The close widget on tabs is a custom one. Web+ devs decided to put it to the right.
I like it on the right, maybe a result of habit after a decade of having it there. It also looks different than the window close button, and I'm OK with that, too.

In the future, we may have the site's favicon at the left of the tab. It would be helpful when having a really huge number of tabs open, as you could at least see the site's icon, even if the title is almost completely trucated. In that case (if it ever gets implemented), having both icon and close widget side by side may not look too nice.

Anyway, I don't see a big gain in the close widget changing sides in the tab.

[pulkomandy]

It is intentionally on the right and looking different than the window one. The same style is used for BNotification. Putting it on the left may be more consistent, but it doesn't look right somehow.

[bitigchi]

Safari uses on-hover close button to make it look cleaner, with favicon and site title centred.

[jackburton]

I agree the close button looks better on the right. We have added on-hover in Genio (which uses WebPositive's tab code) and it looks nice, in fact.

[nephele]

on-hover makes it hard to understand as a user where the close button is. Note that it is also on the left in safari.

In the dark mode currently the X is the wrong color, as a result it is not easily visible (as if it were on-hover) and this leads me to accidentally closing tabs often.

In any case the implementation of tabs in WebPositive is quite bad, tabs in haiku inside applications lend themselves nicely to static content that doesn't change but don't at all for dynamic or reordable content.

I will likely fix this at some point by introducing a vertical tab bar in webpositive instead.

[jackburton]

The problem with dark color is fixed in Genio. I Guess we could port the fixes to web+

[nephele]

If you wish you can create a review on gerrit with the fix and assign me as reviewer :)