Opened 11 months ago

Closed 6 months ago

#18464 closed bug (duplicate)

Unable to rename files in Query/Find

Reported by: shaka Owned by: jscipione
Priority: critical Milestone: R1/beta5
Component: Applications/Tracker Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Platform: All

Description

Running hrev57091 x86_64 and I am unable to rename files in the Query/Find window. A long click on the filename will highlight the app name for editing, but no keyboard input is accepted.

Change History (5)

comment:1 by waddlesplash, 11 months ago

Component: - GeneralApplications/Tracker
Owner: changed from nobody to jscipione
Platform: x86-64All
Status: newassigned

comment:2 by waddlesplash, 6 months ago

Milestone: UnscheduledR1/beta5
Priority: normalcritical

comment:3 by humdinger, 6 months ago

This is a subset of #18661.

comment:4 by jscipione, 6 months ago

I'm pretty sure that this bug report is invalid, but I would like to confirm.

First you have to upgrade to at least hrev57402, which just got committed today and fixes issues with issues renaming files in query windows described by #18661.

Your inability to rename files in Query window should be because those files are on a read-only volume and so the file names can not be edited.

In hrev57402 a gray background is added to the text box to indicate that it is read-only and thus uneditable which will make it quite easy to see. The edit box appears only so that you can copy the name. Previously in R1B4 you could not start the edit name operation on read-only files in the first place.

If you rename a file in a query window that is not read-only, you should see a white background on the text box and the file name should also be editable.

Here is an example of what it should look like:

https://64.media.tumblr.com/e16b1c3c3c8a3c8a8f9d3eea1a8a02b6/fee58a13ee5756f0-76/s1280x1920/8abc123d65056356d3c744ddeed3ed3cb3a43f41.png

This same behavior is also true of all Tracker windows and open/save dialogs so report back if any uneditable files that are not on a read-only volume (remembering that all files included in packages including the system package are read-only).

comment:5 by jscipione, 6 months ago

Resolution: duplicate
Status: assignedclosed

Since he mentioned Query window this is a duplicate of #18661 and so while the bug is valid, it was introduced in hrev56978 and fixed in hrev57402. The gray or white background on the Edit name text box should make it obvious whether editing the name is allowed or not in query windows (although on other windows the background being gray is a bigger hint).

Unfortunately right now it's a bit confusing because query windows get the gray "read-only" background color but are sometimes read-only sometimes writable depending on which file is selected and what operation you're trying to do. Maybe query windows should get a different color background, what is the color of a query?

Fixed in hrev57402 along with #18661.

Note: See TracTickets for help on using tickets.