Opened 17 months ago

Closed 17 months ago

#18510 closed bug (fixed)

Gray triangle on recycle bin icon

Reported by: jmairboeck Owned by: stippi
Priority: normal Milestone: R1/beta5
Component: Kits/libicon.so Version: R1/Development
Keywords: Cc: Zardshard
Blocked By: Blocking:
Platform: All

Description

The recycle bin icon changed in a recent update and gained an extra triangle on top.

It was still okay on hrev57063 and is broken since hrev57146.

Beta 4:

hrev57149:

Attachments (3)

Recycle bin beta4.png​ (4.0 KB ) - added by jmairboeck 17 months ago.
Recycle bin hrev57149.png​ (4.0 KB ) - added by jmairboeck 17 months ago.
Icon-O-Matic_Trash.png​ (86.1 KB ) - added by jmairboeck 17 months ago.
Icon-O-Matic doesn't show the issue.

Download all attachments as: .zip

Change History (13)

by jmairboeck, 17 months ago

Attachment: Recycle bin beta4.png​ added

by jmairboeck, 17 months ago

Attachment: Recycle bin hrev57149.png​ added

comment:1 by waddlesplash, 17 months ago

I don't think the icon has been changed, so this sounds like a regression with the libicon refactoring.

comment:2 by waddlesplash, 17 months ago

Cc: Zardshard added

comment:3 by jmairboeck, 17 months ago

The last change to TrackerIcons.rdef was in 2016 according to git history, so this must indeed be a rendering regression.

comment:4 by pulkomandy, 17 months ago

It looks like the path drawing the edge of the trashcan is being closed (a third line is drawn to connect the start and endpoint) when it shouldn't be.

comment:5 by pulkomandy, 17 months ago

Component: User Interface → Kits/libicon.so
Milestone: Unscheduled → R1/beta5

comment:6 by Starcrasher, 17 months ago

I checked and the icon was still ok with hrev57143.

comment:7 by Zardshard, 17 months ago

Yeah, one of my changes probably caused this. I'm looking into it.

comment:8 by Zardshard, 17 months ago

Finally got a setup where I can test the icon library. Things go wrong at hrev57144.

by jmairboeck, 17 months ago

Attachment: Icon-O-Matic_Trash.png​ added

Icon-O-Matic doesn't show the issue.

comment:9 by Zardshard, 17 months ago

Which is unfortunate, since it makes debugging it harder for me. It happens because of all those #ifdef ICON_O_MATIC's in the icon library.

comment:10 by waddlesplash, 17 months ago

Resolution: → fixed
Status: new → closed

Fix merged in hrev57156.

Note: See TracTickets for help on using tickets.