Can't download commit-msg hook

[jacereda]

According to the instructions at ​https://www.haiku-os.org/guides/building/get-source-git/ the following should work:

sh-5.2# scp -p jacereda@git.haiku-os.org:hooks/commit-msg "haiku/.git/hooks/"
subsystem request failed on channel 0
scp: Connection closed

[jacereda]

Accessing the hook via https as gerrit suggest works fine. Maybe the guide should be updated to use curl instead of scp?

[kallisti5]

err.. wow. That's extremely outdated (pre-gerrit outdated)

​https://gerrit.cloudera.org/Documentation/intro-quick.html is likely more relevant to get started working on Haiku and submitting patches.

We need to update the documentation to drop all of that.

[pulkomandy]

(pre-gerrit outdated)

Certainly not, it was updated to include the Gerrit commit hook downloading. That's the part that's not working here.

Also, if we're going to use Gerrit own documentation, it's better to link to our own instance of it rather than random other instances on the Internets:

​https://review.haiku-os.org/Documentation/intro-quick.html

The documentation from Gerrit for the commit hook is here:

​https://review.haiku-os.org/Documentation/cmd-hook-commit-msg.html

It gives the same instructions:

scp -p -P 29418 <your username>@<your Gerrit review server>:hooks/commit-msg <local path to your git>/.git/hooks/

The problem is known on Gerrit side:

​https://issues.gerritcodereview.com/issues/40014814

The workaround is to add the -O command line switch. However, that switch is not recognized by older versions of openssh scp (before 8.7).

Indeed their solution appears to be "just use http instead" so we should update our docs with that.

[pulkomandy]

Fixed in ​https://github.com/haiku/website/commit/717b4501424724ea4dd1c70b69915c91d38ee5fe