curl examples on 'Get the Haiku Source Code / Pushing Patches ...' is incorrect

[bcbarnes]

Following the instructions in the web page, I get this error message from curl:

Warning: Failed to open the file haiku/.git/hooks/: Is a directory
curl: (23) Failure writing output to destination

Specifically, I think the curl portion of the command is incorrect.

curl -Lo “haiku/.git/hooks/” https://git.haiku-os.org/tools/hooks/commit-msg

The quoted path should have “commit.msg” appended to it, as in “haiku/.git/hooks/commit-msg”.

[humdinger]

I get the same error with and without the suggested change. FWIW, "wget --spider" says:

❯ wget --spider https://git.haiku-os.org/tools/hooks/commit-msg
Spider mode enabled. Check if remote file exists.
--2023-11-07 16:23:25--  https://git.haiku-os.org/tools/hooks/commit-msg
Resolving git.haiku-os.org... 206.189.242.242
Connecting to git.haiku-os.org|206.189.242.242|:443... connected.
HTTP request sent, awaiting response... 404 Not Found
Remote file does not exist -- broken link!!!

[augiedoggie]

Replying to humdinger:

I get the same error with and without the suggested change. FWIW, "wget --spider" says:

❯ wget --spider https://git.haiku-os.org/tools/hooks/commit-msg

I noticed this problem a few weeks ago when setting up git. I used ​https://review.haiku-os.org/tools/hooks/commit-msg to get the proper file.

[bcbarnes]

Something may be going on with the server - I just ran the example and it was fine using curl, but does give the error you see when using wget. Not sure what that is about ...

Perhaps I could have been clearer in my suggested fix. There are 3 examples of 'curl' execution on that web page, each different. The only thing I'm suggesting is that in all 3 examples, a valid destination file name, not a directory, needs to be specified. In all 3 cases, that file name should be "commit-msg". Nothing else is to change.

[pulkomandy]

Fixed in ​https://github.com/haiku/website/commit/84877a0979381b39e22709716c47c6b64cd2c478