Opened 13 months ago

Closed 13 months ago

#18701 closed bug (fixed)

Regression, Boot failure with ACPI enabled

Reported by: bbjimmy Owned by: korli
Priority: high Milestone: R1/beta5
Component: Drivers/ACPI Version: R1/beta4
Keywords: Cc:
Blocked By: Blocking:
Platform: All

Description

updating to hrev57442 on x86_64:

hrev57442 stops at the third boot icon.( hrev57439 worked with ACPI enabled)

After disabling ACPI it boots as normal.

Running on a lenovo ThinkCentre

Attachments (2)

Bitmap.png​ (204.3 KB ) - added by bbjimmy 13 months ago.
DSC_0078.JPG​ (3.9 MB ) - added by pulkomandy 13 months ago.

Change History (11)

by bbjimmy, 13 months ago

Attachment: Bitmap.png​ added

comment:1 by waddlesplash, 13 months ago

Owner: changed from tqh to korli
Status: new → assigned

by pulkomandy, 13 months ago

Attachment: DSC_0078.JPG​ added

comment:2 by pulkomandy, 13 months ago

Milestone: Unscheduled → R1/beta5

comment:3 by pulkomandy, 13 months ago

Same problem on my machine. Attached a picture of the on-screen debug, in case it provides some hints.

comment:4 by korli, 13 months ago

Sorry, I cannot help at the moment. Might always revert the relevant here.

comment:5 by madmax, 13 months ago

If the only intended changes of ​https://git.haiku-os.org/haiku/commit/?id=f2acc47f4363f14c20f645e48aac98f48259de26 were the volatile whatever and the loop exit condition, the return from AcpiOsAcquireGlobalLock should also test ACPI_GLOCK_OWNED to be like the previous version; that is, something like: return (newValue & (ACPI_GLOCK_PENDING | ACPI_GLOCK_OWNED)) != 0;

comment:6 by waddlesplash, 13 months ago

Ah, I see the mistake now in comparison with FreeBSD's methods: ​https://xref.landonf.org/source/xref/freebsd-current/sys/dev/acpica/Osd/OsdSynch.c#607

comment:7 by waddlesplash, 13 months ago

Please retest after hrev57445.

comment:8 by pulkomandy, 13 months ago

Works for me, thanks for the quick investigation :)

comment:9 by pulkomandy, 13 months ago

Resolution: → fixed
Status: assigned → closed
Note: See TracTickets for help on using tickets.