BListView regression: moving the mouse over the view triggers scrolling

[korli]

On nightly moving the mouse over the streams list in StreamRadio triggers scrolling, with or without focus. This is particularly annoying, having StreamRadio near the deskbar, not user friendly.

[waddlesplash]

Sounds like another regression from the list changes. We might want to adjust some of those to avoid breaking BeOS compatibility then...

[waddlesplash]

jscipione: Do you expect to have time to look into this regression?

[X512]

Do reproduction method still work on latest nightly? I feel that some fixes were applied to BListView since opening this ticket.

[jscipione]

I was able to reproduce this bug and it appears to be in StreamRadio. It needs to call BListView::MouseUp(where); at the end of StationListView::MouseUp() to end the scroll.

​https://github.com/HaikuArchives/StreamRadio/blob/master/source/StationListView.cpp#L335

I double checked the list view scrolling code for focus issues but the issues we were having before have been resolved so this is a different regression.

[waddlesplash]

But this is an API break from BeOS, isn't it? Same as with the Icon-O-Matic changes. So we should do something about this in the Interface Kit itself.

[jscipione]

Yeah but you don’t want the list view to select on mouse up instead of mouse down like BeOS did so the ABI break is intentional… I guess.

[X512]

But this is an API break from BeOS, isn't it?

I don't think so because missing superclass method call can be considered as API misuse. So it can be considered as bug per bug BeOS compatibility break, not public API break.

[waddlesplash]

Pushed a fix to StreamRadio in ​https://github.com/HaikuArchives/StreamRadio/commit/c9f178166459f1c1938db7f3a69d8a07b26c76ab.