Opened 10 months ago

Closed 6 months ago

#18745 closed bug (fixed)

BListView regression: moving the mouse over the view triggers scrolling

Reported by: korli Owned by: jscipione
Priority: normal Milestone: R1/beta5
Component: Kits/Interface Kit Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Platform: All

Description

On nightly moving the mouse over the streams list in StreamRadio triggers scrolling, with or without focus. This is particularly annoying, having StreamRadio near the deskbar, not user friendly.

Change History (9)

comment:1 by waddlesplash, 10 months ago

Milestone: UnscheduledR1/beta5
Owner: changed from nobody to jscipione
Status: newassigned

Sounds like another regression from the list changes. We might want to adjust some of those to avoid breaking BeOS compatibility then...

comment:2 by pulkomandy, 10 months ago

Summary: IK: BListView regression: moving the mouse over the view triggers scrollingBListView regression: moving the mouse over the view triggers scrolling

comment:3 by waddlesplash, 7 months ago

jscipione: Do you expect to have time to look into this regression?

comment:4 by X512, 7 months ago

Do reproduction method still work on latest nightly? I feel that some fixes were applied to BListView since opening this ticket.

comment:5 by jscipione, 7 months ago

I was able to reproduce this bug and it appears to be in StreamRadio. It needs to call BListView::MouseUp(where); at the end of StationListView::MouseUp() to end the scroll.

https://github.com/HaikuArchives/StreamRadio/blob/master/source/StationListView.cpp#L335

I double checked the list view scrolling code for focus issues but the issues we were having before have been resolved so this is a different regression.

comment:6 by waddlesplash, 7 months ago

But this is an API break from BeOS, isn't it? Same as with the Icon-O-Matic changes. So we should do something about this in the Interface Kit itself.

comment:7 by jscipione, 7 months ago

Yeah but you don’t want the list view to select on mouse up instead of mouse down like BeOS did so the ABI break is intentional… I guess.

comment:8 by X512, 6 months ago

But this is an API break from BeOS, isn't it?

I don't think so because missing superclass method call can be considered as API misuse. So it can be considered as bug per bug BeOD compatinility break, not public API break.

Version 0, edited 6 months ago by X512 (next)

comment:9 by waddlesplash, 6 months ago

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.