Some QT applications crash on current revision

[bolsen]

Testing this on hrev57662. After updating, these programs I have installed failed to run:

• falkon
• nextcloud
• kolourpaint
• kdevelop
• kstars

They all fail the same way. I think this is related to changes here: ​https://cgit.haiku-os.org/haiku/commit/?id=43d1a0dc3c70d1f9c563769881e5be5a7e67842b. The previous hrev works fine.

[bolsen]

Falkon crash report for main process

[bolsen]

Falkon crash report (for a tab?)

[bolsen]

I posted a dump trying of the OS trying to load Falkon and it does seem that it was attempting to load the executable looking at the stack in the report.

[bolsen]

One other observation for now. Looking at the report, it looks like the line:

const char *semicolon = strchr(rpath, ';'); 

could be the culprit since the "rpath" might be NULL if pathString == runpath. Thus, it might then segfault here.

This is in: src/system/runtime_loader/runtime_loader.cpp

-	// try rpath (DT_RPATH)
-	if (rpath != NULL) {
+	// try runpath or rpath (DT_RUNPATH or DT_RPATH)
+	const char* pathString = runpath;
+	if (pathString == NULL)
+		pathString = rpath;
+	if (pathString != NULL) {
 		// It consists of a colon-separated search path list. Optionally a
 		// second search path list follows, separated from the first by a
 		// semicolon.
 		const char *semicolon = strchr(rpath, ';');
-		const char *firstList = (semicolon ? rpath : NULL);
-		const char *secondList = (semicolon ? semicolon + 1 : rpath);
+		const char *firstList = (semicolon ? pathString : NULL);
+		const char *secondList = (semicolon ? semicolon + 1 : pathString);

[waddlesplash]

Fixed in hrev57664.