Opened 5 months ago

Closed 2 weeks ago

Last modified 2 weeks ago

#19067 closed bug (fixed)

[HaikuDepot] UI: Usages conditions view colours compatibility with dark schemes

Reported by: Starcrasher Owned by: jscipione
Priority: normal Milestone:
Component: Applications/HaikuDepot Version: R1/beta5
Keywords: Cc:
Blocked By: Blocking:
Platform: All

Description

If I understand well, this is the import of an html text. You can make appear that view using "Connexion" or "View last usages conditions"

The view itself seems to always have a white background but the text is taking panel_text_colour. In case of dark schemes this colour is usually very light, making the text unreadable.

Since the idea is to have a separate view, document_background_colour and document_text_colour would do better but perhaps it is not possible. In this case, since the background is white, finding a way to force text to black could work.

Attachments (2)

screenshot3.png (19.4 KB ) - added by Starcrasher 5 months ago.
Usages conditions view
HaikuDepot Usage conditions window dark.png (161.5 KB ) - added by jscipione 2 weeks ago.
Screenshot showing the Usage conditions window with a dark background and light text

Download all attachments as: .zip

Change History (10)

by Starcrasher, 5 months ago

Attachment: screenshot3.png added

Usages conditions view

comment:1 by nephele, 5 months ago

Please retest after hrev58074

comment:2 by waddlesplash, 5 months ago

Milestone: UnscheduledR1/beta5
Resolution: fixed
Status: newclosed

comment:3 by Starcrasher, 5 months ago

Tested on hrev58095 with both 32 bits and 64 bits. The background is now taking document_background_colour but the text is still using panel_text_colour. So, it is still a wrong pair of colours but, somehow it already works better most of the time.

comment:4 by nephele, 5 months ago

Resolution: fixed
Status: closedreopened

comment:5 by jscipione, 5 months ago

Owner: changed from apl-haiku to jscipione
Status: reopenedin-progress

PS to fix (setting the foreground color): https://review.haiku-os.org/c/haiku/+/8262

comment:6 by nephele, 5 months ago

Milestone: R1/beta5

comment:7 by jscipione, 2 weeks ago

Resolution: fixed
Status: in-progressclosed
Type: enhancementbug

The remaining problems have been fixed in hrev58542

by jscipione, 2 weeks ago

Screenshot showing the Usage conditions window with a dark background and light text

comment:8 by Starcrasher, 2 weeks ago

It looks definitely better.

I noticed that the most important one (that you can access on account creation tab) has now a window fully resizeable. Thanks for taking care of that in same time, it makes it really easier to read.

Curiously, the window of standalone version (the one you can reach directly from menu) has fixed width but I guess that it's on purpose for small screen users. If not that belongs to another ticket anyway.

Note: See TracTickets for help on using tickets.