Opened 12 days ago
Closed 8 days ago
#19150 closed bug (fixed)
serial_init() is called at a wrong time for the x86_64 arch
| Reported by: | volodroid | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | R1/beta6 |
| Component: | System/Boot Loader/EFI | Version: | R1/beta5 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | ||
| Platform: | All |
Description
serial_init is called after calling the ExitBootServices on all the archs except of x86_64.
I've created the following patch on GitHub: https://patch-diff.githubusercontent.com/raw/haiku/haiku/pull/27.patch (PR is https://github.com/haiku/haiku/pull/27)
Can you please bring it to Gerrit?
Change History (4)
comment:1 by , 12 days ago
comment:2 by , 12 days ago
Honestly, I don't like working with Gerrit, so I'm not ready yet to registering an account and going through all the Gerrit patch submission process for a simple 2-line patch that might as well be my only contribution to Haiku. But if I ever submit something more, I'll consider signing up.
Some time ago PulkoMandy wrote on the forum it's okay to provide patches outside of the Gerrit and let the dev team know. I hope that's still the case. If not, sorry for the trouble.
comment:3 by , 12 days ago
What patch submission process?
It's a simple "git push" to a special branch named refs/for/master. But yes, there's account creation. We used to use Github account but there were much complaints from people who absolutely don't want to create a Github account. Can't please everyone.
Anyway, it's forwarded to Gerrit: https://review.haiku-os.org/c/haiku/+/8435
comment:4 by , 8 days ago
| Milestone: | Unscheduled → R1/beta6 |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
Fix merged in hrev58215.
Anyone can push patches to Gerrit, see the SubmittingPatches page on Trac. Why not push it yourself?