[enhancement] syslog_daemon should have some "spam protection".

[bipolar]

Since around beta5, media_addon_server regularly misbehaves in my systems: either it crashes at boot, or spams so much the syslog, that one CPU core gets pegged to 100%.

Attaching the resulting /var/log/syslog after I found what was pegging a core this time (not Web+, nice), and after having to kill media_server/media_addon_server a couple of times till started working as intended.

While fixing the issue on media_addon_server would be nice, my suggestion is... if possible... syslog should never be allowed to use so much CPU, or to trash the disk so much.

[waddlesplash]

I don't know if we can or should do anything differently in syslog_daemon here, it's just supposed to write the syslog to disk, so of course when the syslog gets flooded, it uses a lot of CPU.

[bipolar]

I understand, but I had both syslog and syslog.old containing nothing more that the same repeating lines from "hda" as in the attached syslog more than once, so it would be nice to at least have an alert? "Hey... maybe you should check team X, it is acting a bit crazy" :-)

[waddlesplash]

In this case it's the kernel posting these lines.

There is line de-duplication but only for single lines. Perhaps we could fix the HDA driver to not print 2 lines for this error (besides bailing out sooner...)

[waddlesplash]

I fixed this particular log spam in hrev58278. I don't think there's much else we can/should do here.