Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#2038 closed bug (fixed)

[PATCH] Rev 24845 refuses to compile because of a bug in USBKit.h

Reported by: stpere Owned by: axeld
Priority: normal Milestone: R1
Component: - General Version: R1/pre-alpha1
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

There are virtual methods that are declared USBKit.h that are never defined.. it makes the compilation (linking more precisely) fail on my system and other's.

Here is a quick patch to fix the issue.

Attachments (1)

usbkit.diff (1.3 KB ) - added by stpere 11 years ago.
Patch for USBKit.h to fix the compile error

Download all attachments as: .zip

Change History (5)

by stpere, 11 years ago

Attachment: usbkit.diff added

Patch for USBKit.h to fix the compile error

comment:1 by stpere, 11 years ago

Summary: Rev 24845 refuses to compile because of a bug in USBKit.h[PATCH] Rev 24845 refuses to compile because of a bug in USBKit.h

comment:2 by mmlr, 11 years ago

Resolution: fixed
Status: newclosed

I am not absolutely sure if defining those functions inline in the header actually achieves the same, but I've just added them to the respective source file to make sure. Thanks for the note though as I didn't really realize that usb_dev_info is actually using the USBKit and it therefore could break the build. Fixed in hrev24847.

comment:3 by axeld, 11 years ago

BTW, I think the bug tracker is not the right place to use for mentioning a broken build. Please use the mailing list for this kind of problems.

in reply to:  2 comment:4 by jackburton, 11 years ago

Replying to mmlr:

I am not absolutely sure if defining those functions inline in the header actually achieves the same,

I think this would cause problems when we actually use those virtual slots.

Note: See TracTickets for help on using tickets.