#2038 closed bug (fixed)
[PATCH] Rev 24845 refuses to compile because of a bug in USBKit.h
| Reported by: | stpere | Owned by: | axeld |
|---|---|---|---|
| Priority: | normal | Milestone: | R1 |
| Component: | - General | Version: | R1/pre-alpha1 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | ||
| Platform: | All |
Description
There are virtual methods that are declared USBKit.h that are never defined.. it makes the compilation (linking more precisely) fail on my system and other's.
Here is a quick patch to fix the issue.
Attachments (1)
Change History (5)
by , 17 years ago
| Attachment: | usbkit.diff added |
|---|
comment:1 by , 17 years ago
| Summary: | Rev 24845 refuses to compile because of a bug in USBKit.h → [PATCH] Rev 24845 refuses to compile because of a bug in USBKit.h |
|---|
follow-up: 4 comment:2 by , 17 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
I am not absolutely sure if defining those functions inline in the header actually achieves the same, but I've just added them to the respective source file to make sure. Thanks for the note though as I didn't really realize that usb_dev_info is actually using the USBKit and it therefore could break the build. Fixed in hrev24847.
comment:3 by , 17 years ago
BTW, I think the bug tracker is not the right place to use for mentioning a broken build. Please use the mailing list for this kind of problems.
comment:4 by , 17 years ago
Replying to mmlr:
I am not absolutely sure if defining those functions inline in the header actually achieves the same,
I think this would cause problems when we actually use those virtual slots.
Patch for USBKit.h to fix the compile error