Mount point not removed

[andreasf]

When unmounting a volume from DriveSetup, its mount point is not removed.

This leads to a multitude of numbered directories when mounting and unmounting the same volume multiple times.

When unmounting through Tracker, the directory is gone, as expected.

[stippi]

Good point. I am using BPartition::Unmount() directly, but it is BVolume which takes care of removing the mount point if it is called the same as the partition. I should just switch to using that...

[bonefish]

Replying to stippi:

Good point. I am using BPartition::Unmount() directly, but it is BVolume which takes care of removing the mount point if it is called the same as the partition. I should just switch to using that...

Or adjust BPartition::Unmount(). Maybe add a boolean removeMountPoint flag?

[axeld]

There is no BVolume::Unmount(), actually. Tracker just deletes the mount point manually. Of course, if Mount() creates the mount point, Unmount() should remove it - otherwise it really shouldn't, though (as you might want to mount a volume not on root level).

[bonefish]

Replying to axeld:

There is no BVolume::Unmount(), actually. Tracker just deletes the mount point manually. Of course, if Mount() creates the mount point, Unmount() should remove it - otherwise it really shouldn't, though (as you might want to mount a volume not on root level).

Mount() gets the mount point as optional argument. If one is given it expects it to exist. If not given, the standard mount point is created. Hence my suggestion to add a flag to Unmount().

[andreasf]

Sounds like hrev26593 might have resolved this issue?

[stippi]

Yes, thanks. Fixed in hrev26593.