Possible 'strsignal' keyword issue in posix/signal.h

[scottmc]

While trying to build ntp, make fails with this output:

gcc -DHAVE_CONFIG_H -I. -I. -I.. -I.. -g -O2 -Wall -Wcast-qual
-Wmissing-prototypes -Wpointer-arith -Wshadow -Wstrict-prototypes -c
libopts.c -Wp,-MD,.deps/libopts_la-libopts.TPlo -o
libopts_la-libopts.o
In file included from /boot/develop/headers/posix/sys/wait.h:9,
                from /boot/home/ntp-4.2.4p4/libopts/compat/compat.h:48,
                from /boot/home/ntp-4.2.4p4/libopts/libopts.c:2:
/boot/develop/headers/posix/signal.h:175: conflicting types for `strsignal'
/boot/home/ntp-4.2.4p4/libopts/compat/compat.h:28: previous
declaration of `strsignal'
In file included from /boot/develop/headers/posix/memory.h:1,
                from /boot/home/ntp-4.2.4p4/libopts/compat/compat.h:141,
                from /boot/home/ntp-4.2.4p4/libopts/libopts.c:2:
/boot/develop/headers/posix/string.h:74: warning: declaration of
`signal' shadows global declaration
/boot/home/ntp-4.2.4p4/libopts/autoopts.c: In function `handleOption':
In file included from /boot/home/ntp-4.2.4p4/libopts/libopts.c:9:
/boot/home/ntp-4.2.4p4/libopts/autoopts.c:154: warning: cast discards
qualifiers from pointer target type
....many more warnings...

​ntp port log

[axeld]

That hints to a configuration problem of ntp; it might not properly detect the presence of strsignal() on the target platform. strsignal() itself is not a POSIX function, but usually is provided by Unix systems, and has the signature as provided by Haiku's signal.h header albeit usually without the "const".

[scottmc]

Ok, I'll have a closer look at it. Wasn't sure if this was the same type of issue as restrict or if it was a cinfiguration issue. I'll check through the config.log closer and see what i turn up.

[kaliber]

The bugs are in the ntp software. I have created preliminary patch for it ​http://svn.gna.org/viewcvs/pingwinek/trunk/packages/ntp/ntp-haiku.patch but the main problem is lack of adjtime() in haiku. You can try to create enhancement request ;)