Opened 16 years ago
Closed 13 years ago
#2482 closed bug (fixed)
Panic while automounting usb stick
| Reported by: | emitrax | Owned by: | mmlr |
|---|---|---|---|
| Priority: | normal | Milestone: | R1 |
| Component: | Drivers/Disk | Version: | R1/pre-alpha1 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | ||
| Platform: | All |
Description
It seems it happens only on first boot, but I'm not sure whether it is a coincidence, those a race condition, or not.
See screenshots attached.
Attachments (2)
Change History (7)
by , 16 years ago
| Attachment: | AutoMounter.4.jpg added |
|---|
by , 16 years ago
| Attachment: | add_poses.jpg added |
|---|
comment:1 by , 16 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
comment:2 by , 16 years ago
Any news on this? It's possible that the device locked up because of error recovery not working and that causing the timeout. Could you please check if a current revision >= hrev28934 still exhibits this problem?
comment:3 by , 16 years ago
I just gave it a quick test and I did the following:
1 - plug the stick 2 - mount it 3 - open it 4 - close it 5 - right click on the icon -> unmount
icon does not disappear, plus using the right click menu of the desktop and going to the mount entry makes the menu hang in the there. hrev28958.
comment:4 by , 15 years ago
So the original issue isn't reproducible anymore? The other issue mentioned in comment 3 would deserve a new bug report if it is still happening. Otherwise I'd like to close this one.
comment:5 by , 13 years ago
| Component: | - General → Drivers/Disk |
|---|---|
| Resolution: | → fixed |
| Status: | in-progress → closed |
Probably fixed.
This is not a race condition or anything, it's a plain simple timeout that happens. The device does not respond quickly enough therefore usb_disk will abort and return a timeout error ("error: Operation timed out"). The timeout I (arbitrarily) set is 2 seconds right now, which might just not be enough. Please increase the timeout in src/add-ons/kernel/drivers/disk/usb/usb_disk/usb_disk.cpp line 145 by a second until you don't see this happening anymore and report how much it needs. Other subsystems seem to use timeouts of up to 20 seconds, but I don't really want to increase it that much. Maybe 3 or 5 seconds would be acceptable though.