Opened 11 years ago

Closed 11 years ago

#2484 closed bug (invalid)

FindPetition doesn't handle cases when event has alternative opcodes

Reported by: monni Owned by: oruizdorantes
Priority: normal Milestone: R1
Component: Network & Internet/Bluetooth Version: R1/pre-alpha1
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

When trying to find matching message, LocalDeviceHandler::FindPetition stops looking for correct message if event matches but opcode isn't correct. In some cases there is alternative opcodes for same event.

Experienced behaviour: Message is not found Expected behaviour: continue looking until opcode matches or runs out of subitems in fEventsWanted.

Attachments (1)

LocalDeviceHandler.diff (615 bytes ) - added by monni 11 years ago.
Patch to change behaviour of FindPetition

Download all attachments as: .zip

Change History (3)

by monni, 11 years ago

Attachment: LocalDeviceHandler.diff added

Patch to change behaviour of FindPetition

comment:1 by oruizdorantes, 11 years ago

The idea is that each opcodeExpected index inside the BMessage has to match its eventExpected index.

There are 2 different events that contains Opcode (CommandStatus and CommandComplete) they cannot be inside the request with a ramdom index. You can achieve this by Adding first those pairs in the request and last events the ones which do not require opcode.

So it is actually the expected/needed behaviour.

comment:2 by oruizdorantes, 11 years ago

Resolution: invalid
Status: newclosed
Note: See TracTickets for help on using tickets.