Opened 16 years ago
Closed 16 years ago
#2827 closed bug (fixed)
[Pe] Save As dialog box has over lapping button (easy)
Reported by: | scottmc | Owned by: | axeld |
---|---|---|---|
Priority: | normal | Milestone: | R1 |
Component: | - General | Version: | R1/pre-alpha1 |
Keywords: | Cc: | ||
Blocked By: | Blocking: | ||
Platform: | All |
Description
The Save As dialog box for Pe has the type drop down overlapping the cancel button. I suspect this points to something wrong in Haiku?
Attachments (2)
Change History (9)
by , 16 years ago
Attachment: | pe-save-as.png added |
---|
comment:1 by , 16 years ago
comment:2 by , 16 years ago
Summary: | [Pe] Save As dialog box has over lapping button → [Pe] Save As dialog box has over lapping button (easy) |
---|
by , 16 years ago
comment:3 by , 16 years ago
The patch reorganizes the SavePanel to look like other SavePanels which have a "FileType" menu.
(Indeed I have copied a lot on the source code of Icon-o-matic. :)
comment:4 by , 16 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Applied Maxime's patch in hrev555 of Pe's repo - thanks!
Maxime: as given, your patch did not work at all under BeOS R5 and it took me some time of debugging to find out that it was simply using an uninitialized font-height structure. Haiku just happens to have some appropriate value on the stack then, while R5 does not ;-) I took the liberty to fix that by initializing the struct via be_plain_font->GetHeight().
comment:5 by , 16 years ago
Really sorry about that, I did just have Haiku as BeOS-like on which to test.
comment:6 by , 16 years ago
Resolution: | fixed |
---|---|
Status: | closed → reopened |
Reopening... the patch fixes the issue, but we still need to get the updated Pe into the image. Once someone posts a new Pe binary from hrev555 or newer, and adds it to the Optional Packages, then this ticket can be closed.
comment:7 by , 16 years ago
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
I built Pe on Haiku, called it 2.4.2 and updated the optional packages file in hrev30153.
This still happens with PE-2.4.1-RC3 on hrev28589.