Opened 11 years ago

Closed 10 years ago

#2904 closed bug (fixed)

libsdl joystick issues

Reported by: scottmc Owned by: jackburton
Priority: normal Milestone: R1
Component: - General Version: R1/pre-alpha1
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

While trying to build 1.2 branch svn version of libsdl (on hrev28118), I run into issues with the recent Joystick.h changes.

/bin/sh ./libtool --mode=compile gcc -g -O2  -I./include -D_GNU_SOURCE=1 -c ./src/video/bwindow/SDL_syswm.cc  -o build/SDL_syswm.lo
 gcc -g -O2 -I./include -D_GNU_SOURCE=1 -c ./src/video/bwindow/SDL_syswm.cc  -DPIC -o build/.libs/SDL_syswm.o
 gcc -g -O2 -I./include -D_GNU_SOURCE=1 -c ./src/video/bwindow/SDL_syswm.cc -o build/SDL_syswm.o >/dev/null 2>&1
/bin/sh ./libtool --mode=compile gcc -g -O2  -I./include -D_GNU_SOURCE=1 -c ./src/video/bwindow/SDL_sysyuv.cc  -o build/SDL_sysyuv.lo
 gcc -g -O2 -I./include -D_GNU_SOURCE=1 -c ./src/video/bwindow/SDL_sysyuv.cc  -DPIC -o build/.libs/SDL_sysyuv.o
 gcc -g -O2 -I./include -D_GNU_SOURCE=1 -c ./src/video/bwindow/SDL_sysyuv.cc -o build/SDL_sysyuv.o >/dev/null 2>&1
/bin/sh ./libtool --mode=compile gcc -g -O2  -I./include -D_GNU_SOURCE=1 -c ./src/joystick/beos/SDL_bejoystick.cc  -o build/SDL_bejoystick.lo
 gcc -g -O2 -I./include -D_GNU_SOURCE=1 -c ./src/joystick/beos/SDL_bejoystick.cc  -DPIC -o build/.libs/SDL_bejoystick.o
In file included from /boot/home/develop/sdl/src/joystick/beos/SDL_bejoystick.cc:29:
/boot/develop/headers/be/device/Joystick.h:34: field `name_axis' has incomplete type
/boot/develop/headers/be/device/Joystick.h:35: field `name_hat' has incomplete type
/boot/develop/headers/be/device/Joystick.h:36: field `name_button' has incomplete type
/boot/home/develop/sdl/src/joystick/beos/SDL_bejoystick.cc: In function `int SDL_SYS_JoystickInit()':
/boot/home/develop/sdl/src/joystick/beos/SDL_bejoystick.cc:72: call of overloaded `Open(char[32])' is ambiguous
/boot/develop/headers/be/device/Joystick.h:46: candidates are: status_t BJoystick::Open(const char *)
/boot/develop/headers/be/device/Joystick.h:47:                 status_t BJoystick::Open(const char *, bool = true)
/boot/home/develop/sdl/src/joystick/beos/SDL_bejoystick.cc: In function `int SDL_SYS_JoystickOpen(SDL_Joystick *)':
/boot/home/develop/sdl/src/joystick/beos/SDL_bejoystick.cc:113: call of overloaded `Open(char *&)' is ambiguous
/boot/develop/headers/be/device/Joystick.h:46: candidates are: status_t BJoystick::Open(const char *)
/boot/develop/headers/be/device/Joystick.h:47:                 status_t BJoystick::Open(const char *, bool = true)
make: *** [build/SDL_bejoystick.lo] Error 1
~/develop/sdl> 

Change History (7)

comment:1 Changed 11 years ago by kaliber

The same situation exist in the Allegro library.

comment:2 Changed 11 years ago by jackburton

Owner: changed from axeld to jackburton

I'm on it.

comment:3 Changed 11 years ago by jackburton

Status: newassigned

Should be fixed in hrev28291.

comment:5 Changed 11 years ago by jackburton

Yes. The first Open() version (the one without the bool parameter) always enter enhanced mode, so it's just like calling the second version with "true" as second parameter.

comment:6 Changed 10 years ago by scottmc

I was able to build libSDL 1.2-svn-4114 on hrev28291, but I had some troubles getting the tests to run. I'll give it another try in the next few days here. Close this one and if the trouble comes back I'll reopen it, but I suspect hrev28291 did indeed fix this.

comment:7 Changed 10 years ago by jackburton

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.