Opened 13 years ago

Closed 13 years ago

Last modified 12 years ago

#300 closed bug (fixed)

BChannelSlider broken

Reported by: marcusoverhagen Owned by: jackburton
Priority: high Milestone: R1
Component: - General Version:
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

BChannelSlider is drawn wrong and is unusable. See screenshot

Attachments (2)

screen7.png (70.7 KB) - added by marcusoverhagen 13 years ago.
The channel control are broken
screen9.png (15.8 KB) - added by marcusoverhagen 13 years ago.
ChannelSliderTest also shows the problem

Download all attachments as: .zip

Change History (14)

comment:1 Changed 13 years ago by axeld

Owner: changed from bpmagic@… to jackburton

Changed 13 years ago by marcusoverhagen

Attachment: screen7.png added

The channel control are broken

comment:2 Changed 13 years ago by korli

Last time I tried, ChannelSliderTest worked on Dano. Could it be related to the app_server ?

Changed 13 years ago by marcusoverhagen

Attachment: screen9.png added

ChannelSliderTest also shows the problem

comment:3 Changed 13 years ago by jackburton

I tested today on beos R5 and it works fine. Definitely it's something somewhere else. Will have a look.

comment:4 Changed 13 years ago by jackburton

Status: newassigned

comment:5 Changed 13 years ago by jackburton

Resolution: fixed

comment:6 Changed 13 years ago by jackburton

Status: assignedclosed

comment:7 Changed 13 years ago by jackburton

Fixed in rev 16774

comment:8 Changed 13 years ago by korli

Cc: superstippi@… added

comment:9 Changed 13 years ago by korli

Is the bug in app_server which caused this fixed ? I think Stefano only fixed it in ChannelSlider.cpp.

comment:10 Changed 13 years ago by jackburton

Yes, I only fixed in ChannelSlider. The problem in the app_server is still there.

comment:11 Changed 12 years ago by korli

Platform: All

Finally fixed in revision 20388 plus revision 20391. Media preferences now shows correctly positioned sliders.

I'm wondering if it is that useful to draw the actual slider value on the thumb, ie for a BContinuousParameter limited to (-34.5, 12), displayed values are from -345 to 120 ... and still not taking into account a possible response (see BContinousParameter::SetResponse() http://www.beunited.org/bebook/The%20Media%20Kit/ContinuousParameter.html#GetResponse() ).

comment:12 in reply to:  11 Changed 12 years ago by jackburton

Replying to korli:

Finally fixed in revision 20388 plus revision 20391. Media preferences now shows correctly positioned sliders.

I'm wondering if it is that useful to draw the actual slider value on the thumb, ie for a BContinuousParameter limited to (-34.5, 12), displayed values are from -345 to 120 ... and still not taking into account a possible response (see BContinousParameter::SetResponse() http://www.beunited.org/bebook/The%20Media%20Kit/ContinuousParameter.html#GetResponse() ).

It's probably useless, at least how it's done now. There was a discussion long ago about this feature, but I think it can be removed, at least if we don't find a nice way to implement this.

Note: See TracTickets for help on using tickets.