[DriveSetup] should open main window without bottom scrollbar (easy)

[diver]

Just to look more polished.

[harsha]

increased the window width. check the screen shot and let me know.

thanks, _harsha

[scottmc]

looks good. now just create and attach a patch to the ticket.

[stippi]

Sorry, didn't notice the patch, but it didn't fix the actual problem. However, I have meanwhile come up with a fix that will always try to open the window such that scrolling is not necessary and also all the columns have their preferred width.

[stippi]

Fixed in hrev32853, forgot to mention.

[diver]

Still reproducible in hrev32886, reopening.

[diver]

note truncated ata/master

[diver]

I've attached screenshot to show current view. Double clicking column separator doesn't change anything.

[jacob.simpson]

Expand window size to make horizonatal scrollbar inactive.

[jacob.simpson]

If I understand what is posted in this ticket, there are two issues.

1. The issue that started the ticket seems to be about the horizontal scroll bar being active at the default window sizing when viewing the partition list.

2. In certain circumstances, when the Device column is double clicked on the separator, it doesn't resize to display all the text in all the cells of the column without collapsing. Documented in comment:ticket:3036:7

I have attached a patch which I believe addresses issue 1.

[diver]

Still here in hrev35141.

[diver]

There is a patch attached to this ticket. Maybe someone could look at it?
To reproduce this problem one could use:

jam -j2 -q haiku-anyboot-imagege
qemu -cdrom haiku/trunk/generated.x86gcc2/haiku-anyboot.image

[stippi]

The patch is not a good solution, since obviously BColumnListView::PreferredSize() is expected to return the correct size. The problem simply does not bother me enough so I was too lazy to look into it. :-}

[Duggan]

Fixes ColumnListView width issues

[Duggan]

I looked at this a little bit and it seems the issue is caused by TitleView::_VirtualWidth() returning the incorrect width. A patch has been submitted for review.

[Duggan]

There's another issue now (or still?) where if the virtual width is larger than the width and scrolled entirely right and the size is then reduced, the scrollbar becomes inaccurate. I'll attempt to work on that next.

[Duggan]

I see what the other issue that was being referred is and I'll start taking a look at it as well. Also, the rightmost column part can be exceptionally difficult to grab as its right on the edge with the vertical scrollbar, so maybe adding a couple pixels of width wouldn't hurt, but not nearly as much as before.

[Ziusudra]

I've noticed that grabbing that rightmost column divider is an issue in Tracker, too. When the window is zoomed to the optimum size in details view mode, there seems to be only a 2 pixel wide area to grab and the divider is actually covered by the scroll bar. Oh, look a ticket: #4318

Also, I think that the DriveSetup should be made zoomable in the same way as Tracker.

[Ziusudra]

Created ticket for zoom enhancement: #6265

[stippi]

Fixed for real in hrev38374. When you confirm the fix, make sure to remove the DriveSetup settings file in which it remembers its window position.