Opened 10 years ago

Closed 10 years ago

#3141 closed bug (fixed)

flock does not check the operation argument for validity

Reported by: bhaible Owned by: axeld
Priority: normal Milestone: R1
Component: System/Kernel Version: R1/pre-alpha1
Keywords: Cc: olive@…
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

The flock() function does not return an error code when the operation argument is invalid. In the attached sample program a shared and exclusive lock is requested - obviously nonsense, but the BeOS implementation does not reject it.

Expected output: -1 and the value of EINVAL Actual output: 0 0

flock() is not specified by POSIX, therefore one has to look at the manual pages of some systems, such as Linux

http://www.kernel.org/doc/man-pages/online/pages/man2/flock.2.html

or NetBSD

http://www.daemon-systems.org/man/flock.2.html

Attachments (2)

flock-bug.c (560 bytes) - added by bhaible 10 years ago.
test case
haiku-flock-bug.png (1.9 KB) - added by bhaible 10 years ago.

Download all attachments as: .zip

Change History (5)

Changed 10 years ago by bhaible

Attachment: flock-bug.c added

test case

Changed 10 years ago by bhaible

Attachment: haiku-flock-bug.png added

comment:1 Changed 10 years ago by karmak

Cc: olive@… added

comment:2 Changed 10 years ago by axeld

Thanks! The bug is gone with hrev28889.

comment:3 Changed 10 years ago by axeld

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.