Opened 15 years ago
Last modified 4 years ago
#3358 assigned enhancement
Move the directory move check into the VFS layer
| Reported by: | axeld | Owned by: | nobody |
|---|---|---|---|
| Priority: | low | Milestone: | R1.1 |
| Component: | System/Kernel | Version: | R1/pre-alpha1 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | ||
| Platform: | All |
Description
When moving a directory, we currently burden the check to not move the directory into itself on the file systems.
This should better be done in the VFS layer instead, so all file systems can benefit from it.
Change History (4)
comment:1 by , 7 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
comment:2 by , 6 years ago
comment:3 by , 4 years ago
Still relevant as far as I can see. The code to check this is in kernel_interface.cpp for bfs at line 1205 ("Don't move a directory into one of it's childre" as a comment). It should be moved, if I'm reading this right, to src/kernel/fs/vfs.cpp in the common_rename function.
comment:4 by , 4 years ago
| Milestone: | R1 → R1.1 |
|---|
Note:
See TracTickets
for help on using tickets.
Still relevant?