Opened 16 years ago
Closed 16 years ago
#3620 closed enhancement (fixed)
Allow Command-Q to hide Tracker's Preferences
Reported by: | jonas.kirilla | Owned by: | axeld |
---|---|---|---|
Priority: | normal | Milestone: | R1 |
Component: | Applications/Tracker | Version: | R1/pre-alpha1 |
Keywords: | Cc: | ||
Blocked By: | Blocking: | ||
Platform: | All |
Description
From a user point of view the Tracker Preferences may appear to be a stand-alone application, since it can be launched that way now. People will try to close it by Command-Q and find that it doesn't work. Hardly the end of the world, but some are likely to find it annoying.
There are plenty of other applications where people can learn the difference between Command-Q and Command-W, in a more meaningful way.
This patch lets you Command-Q to hide Tracker's Preferences.
Please do comment on code guideline compliance.
Attachments (1)
Change History (2)
by , 16 years ago
Attachment: | Tracker.cpp.diff added |
---|
comment:1 by , 16 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Thanks a lot! Commited in hrev29772. Coding style was just fine. The only thing I could possibly point out is that some of the nesting could be avoided like:
// but allow quitting to hide fSettingsWindow int32 index = 0; BWindow *window = NULL; while ((window = WindowAt(index++)) != NULL) { if (window != fSettingsWindow) continue; if (fSettingsWindow->Lock()) { if (!fSettingsWindow->IsHidden() && fSettingsWindow->IsActive()) fSettingsWindow->Hide(); fSettingsWindow->Unlock(); } break; }
But like I said, it was just fine before. :-)
Tracker.cpp.diff